[CLI-352] Correct HelpFormatter Javadoc (#418)

* [CLI-352] Correct HelpFormatter Javadoc

* [CLI-352] Correct HelpFormatter Javadoc

* Use overloaded builder method
to define option rather than specifiying it separately. This will be more consistent with other documented uses.

---------

Co-authored-by: Ken Dombeck <[email protected]>

Author: kdombeck

src/main/java/org/apache/commons/cli/HelpFormatter.java

@@ -44,9 +44,9 @@ Licensed to the Apache Software Foundation (ASF) under one or more
  * </p>
  * <pre>
  * Options options = new Options();
- * options.addOption(OptionBuilder.withLongOpt("file").withDescription("The file to be processed").hasArg().withArgName("FILE").isRequired().create('f'));
- * options.addOption(OptionBuilder.withLongOpt("version").withDescription("Print the version of the application").create('v'));
- * options.addOption(OptionBuilder.withLongOpt("help").create('h'));
+ * options.addOption(Option.builder("f").longOpt("file").desc("The file to be processed").hasArg().argName("FILE").required().get());
+ * options.addOption(Option.builder("v").longOpt("version").desc("Print the version of the application").get());
+ * options.addOption(Option.builder("h").longOpt("help").get());
  *
  * String header = "Do something useful with an input file\n\n";
  * String footer = "\nPlease report issues at https://example.com/issues";

src/main/java/org/apache/commons/cli/help/HelpFormatter.java

@@ -31,14 +31,14 @@ Licensed to the Apache Software Foundation (ASF) under one or more
  *
  * <pre>
  * Options options = new Options();
- * options.addOption(OptionBuilder.withLongOpt("file").withDescription("The file to be processed").hasArg().withArgName("FILE").isRequired().create('f'));
- * options.addOption(OptionBuilder.withLongOpt("version").withDescription("Print the version of the application").create('v'));
- * options.addOption(OptionBuilder.withLongOpt("help").create('h'));
+ * options.addOption(Option.builder("f").longOpt("file").desc("The file to be processed").hasArg().argName("FILE").required().get());
+ * options.addOption(Option.builder("v").longOpt("version").desc("Print the version of the application").get());
+ * options.addOption(Option.builder("h").longOpt("help").get());
  *
  * String header = "Do something useful with an input file";
  * String footer = "Please report issues at https://example.com/issues";
  *
- * HelpFormatter formatter = new HelpFormatter();
+ * HelpFormatter formatter = HelpFormatter.builder().get();
  * formatter.printHelp("myapp", header, options, footer, true);
  * </pre>
  * <p>