Remove redundant checks for whitespace in

DaitchMokotoffSoundex.soundex(String, boolean)

- Whitespace are already removed in cleanup() before we get to the
additional check
- Remove extra vertical whitespace

Author: garydgregory

src/changes/changes.xml

@@ -53,6 +53,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Precompile regular expressions in Lang.loadFromResource(String, Languages).</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Precompile regular expressions in PhoneticEngine.encode(String, LanguageSet).</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Precompile regular expressions in org.apache.commons.codec.language.bm.Rule.parse*(*).</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Remove redundant checks for whitespace in DaitchMokotoffSoundex.soundex(String, boolean).</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add HmacUtils.hmac(Path).</action>      
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add HmacUtils.hmacHex(Path).</action>      

src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java

@@ -464,30 +464,19 @@ private String[] soundex(final String source, final boolean branching) {
         if (source == null) {
             return null;
         }
-
         final String input = cleanup(source);
-
         final Set<Branch> currentBranches = new LinkedHashSet<>();
         currentBranches.add(new Branch());
-
         char lastChar = NUL;
         for (int index = 0; index < input.length(); index++) {
             final char ch = input.charAt(index);
-
-            // ignore whitespace inside a name
-            if (Character.isWhitespace(ch)) {
-                continue;
-            }
-
             final String inputContext = input.substring(index);
             final List<Rule> rules = RULES.get(ch);
             if (rules == null) {
                 continue;
             }
-
             // use an EMPTY_LIST to avoid false positive warnings wrt potential null pointer access
             final List<Branch> nextBranches = branching ? new ArrayList<>() : Collections.emptyList();
-
             for (final Rule rule : rules) {
                 if (rule.matches(inputContext)) {
                     if (branching) {
@@ -512,7 +501,6 @@ private String[] soundex(final String source, final boolean branching) {
                             nextBranches.add(nextBranch);
                         }
                     }
-
                     if (branching) {
                         currentBranches.clear();
                         currentBranches.addAll(nextBranches);
@@ -521,17 +509,14 @@ private String[] soundex(final String source, final boolean branching) {
                     break;
                 }
             }
-
             lastChar = ch;
         }
-
         final String[] result = new String[currentBranches.size()];
         int index = 0;
         for (final Branch branch : currentBranches) {
             branch.finish();
             result[index++] = branch.toString();
         }
-
         return result;
     }
 }