Refactor DigestUtils.updateDigest(MessageDigest, File) to use NIO

Reduce vertical whitespace

Author: garydgregory

src/changes/changes.xml

@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
     <release version="1.18.1" date="YYYY-MM-DD" description="This is a feature and maintenance release. Java 8 or later is required.">
       <!-- FIX -->
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Remove -nouses directive from maven-bundle-plugin. OSGi package imports now state 'uses' definitions for package imports, this doesn't affect JPMS (from org.apache.commons:commons-parent:80).</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Refactor DigestUtils.updateDigest(MessageDigest, File) to use NIO.</action>
       <!-- ADD -->
       <!-- UPDATE -->
       <action type="update" dev="ggregory" due-to="Gary Gregory">Bump org.apache.commons:commons-parent from 79 to 81.</action>

src/main/java/org/apache/commons/codec/digest/DigestUtils.java

@@ -19,7 +19,6 @@
 
 import java.io.BufferedInputStream;
 import java.io.File;
-import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.RandomAccessFile;
@@ -1276,9 +1275,7 @@ public static MessageDigest updateDigest(final MessageDigest messageDigest, fina
      * @since 1.11
      */
     public static MessageDigest updateDigest(final MessageDigest digest, final File data) throws IOException {
-        try (BufferedInputStream inputStream = new BufferedInputStream(new FileInputStream(data))) {
-            return updateDigest(digest, inputStream);
-        }
+        return updateDigest(digest, data.toPath());
     }
 
     /**
@@ -1314,12 +1311,10 @@ private static MessageDigest updateDigest(final MessageDigest digest, final File
     public static MessageDigest updateDigest(final MessageDigest digest, final InputStream inputStream) throws IOException {
         final byte[] buffer = new byte[BUFFER_SIZE];
         int read = inputStream.read(buffer, 0, BUFFER_SIZE);
-
         while (read > -1) {
             digest.update(buffer, 0, read);
             read = inputStream.read(buffer, 0, BUFFER_SIZE);
         }
-
         return digest;
     }