Precompile patterns.

Author: garydgregory

src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java

@@ -25,6 +25,7 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.time.Duration;
+import java.util.regex.Pattern;
 
 import org.apache.commons.codec.AbstractStringEncoderTest;
 import org.apache.commons.codec.EncoderException;
@@ -35,6 +36,9 @@
  * Tests BeiderMorseEncoder.
  */
 class BeiderMorseEncoderTest extends AbstractStringEncoderTest<StringEncoder> {
+
+    private static final Pattern PIPE_PATTERN = Pattern.compile("\\|");
+
     private static final char[] TEST_CHARS = { 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'o', 'u' };
 
     private void assertNotEmpty(final BeiderMorseEncoder bmpm, final String value) throws EncoderException {
@@ -151,7 +155,7 @@ void testOOM() throws EncoderException {
         final String phonemes = encoder.encode(phrase);
         assertFalse(phonemes.isEmpty());
 
-        final String[] phonemeArr = phonemes.split("\\|");
+        final String[] phonemeArr = PIPE_PATTERN.split(phonemes);
         assertTrue(phonemeArr.length <= 10);
     }
 

src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineRegressionTest.java

@@ -23,6 +23,7 @@
 import java.util.HashSet;
 import java.util.Map;
 import java.util.TreeMap;
+import java.util.regex.Pattern;
 
 import org.junit.jupiter.api.Test;
 
@@ -31,6 +32,8 @@
  */
 class PhoneticEngineRegressionTest {
 
+    private static final Pattern COMMA_PATTERN = Pattern.compile(",");
+
     /**
      * This code is similar in style to code found in Solr:
      * solr/core/src/java/org/apache/solr/analysis/BeiderMorseFilterFactory.java
@@ -57,7 +60,7 @@ private static String encode(final Map<String, String> args, final boolean conca
         if (languageSetArg == null || languageSetArg.equals("auto")) {
             languageSet = null;
         } else {
-            languageSet = Languages.LanguageSet.from(new HashSet<>(Arrays.asList(languageSetArg.split(","))));
+            languageSet = Languages.LanguageSet.from(new HashSet<>(Arrays.asList(COMMA_PATTERN.split(languageSetArg))));
         }
 
         /*

src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineTest.java

@@ -20,6 +20,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import java.util.regex.Pattern;
 import java.util.stream.Stream;
 
 import org.junit.jupiter.params.ParameterizedTest;
@@ -33,6 +34,9 @@ class PhoneticEngineTest {
 
     private static final Integer TEN = Integer.valueOf(10);
 
+    private static final Pattern PIPE_PATTERN = Pattern.compile("\\|");
+    private static final Pattern MINUS_PATTERN = Pattern.compile("-");
+
     public static Stream<Arguments> data() {
         // @formatter:off
         return Stream.of(
@@ -73,12 +77,12 @@ void testEncode(final String name, final String phoneticExpected, final NameType
         assertEquals(phoneticExpected, phoneticActual, "phoneme incorrect");
 
         if (concat) {
-            final String[] split = phoneticActual.split("\\|");
+            final String[] split = PIPE_PATTERN.split(phoneticActual);
             assertTrue(split.length <= maxPhonemes);
         } else {
-            final String[] words = phoneticActual.split("-");
+            final String[] words = MINUS_PATTERN.split(phoneticActual);
             for (final String word : words) {
-                final String[] split = word.split("\\|");
+                final String[] split = PIPE_PATTERN.split(word);
                 assertTrue(split.length <= maxPhonemes);
             }
         }