Fix PMD EmptyControlStatement in

org.apache.commons.codec.language.Metaphone

Author: garydgregory

src/changes/changes.xml

@@ -62,6 +62,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UnusedFormalParameter in private constructor in org.apache.commons.codec.binary.Base16.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD multiple UnnecessaryFullyQualifiedName in org.apache.commons.codec.digest.Blake3.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in org.apache.commons.codec.digest.Md5Crypt.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD EmptyControlStatement in org.apache.commons.codec.language.Metaphone.</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add HmacUtils.hmac(Path).</action>      
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add HmacUtils.hmacHex(Path).</action>      

src/main/java/org/apache/commons/codec/language/Metaphone.java

@@ -228,9 +228,8 @@ public String metaphone(final String txt) {
         while (code.length() < getMaxCodeLen() && n < wdsz) { // max code size of 4 works well
             final char symb = local.charAt(n);
             // remove duplicate letters except C
-            if (symb != 'C' && isPreviousChar(local, n, symb)) {
-                // empty
-            } else { // not dup
+            if (symb == 'C' || !isPreviousChar(local, n, symb)) {
+                // not dup
                 switch (symb) {
                 case 'A':
                 case 'E':