Add Checkstyle RedundantModifier

Author: garydgregory

src/conf/checkstyle.xml

@@ -72,6 +72,7 @@ limitations under the License.
     </module>
     <module name="ParenPad" />
     <module name="RedundantImport" />
+    <module name="RedundantModifier" />
     <module name="WhitespaceAfter" />
     <module name="WhitespaceAround" />
   </module>

src/main/java/org/apache/commons/codec/digest/DigestUtils.java

@@ -1276,7 +1276,7 @@ public static MessageDigest updateDigest(final MessageDigest messageDigest, fina
      * @since 1.11
      */
     public static MessageDigest updateDigest(final MessageDigest digest, final File data) throws IOException {
-        try (final BufferedInputStream inputStream = new BufferedInputStream(new FileInputStream(data))) {
+        try (BufferedInputStream inputStream = new BufferedInputStream(new FileInputStream(data))) {
             return updateDigest(digest, inputStream);
         }
     }
@@ -1334,7 +1334,7 @@ public static MessageDigest updateDigest(final MessageDigest digest, final Input
      * @since 1.14
      */
     public static MessageDigest updateDigest(final MessageDigest digest, final Path path, final OpenOption... options) throws IOException {
-        try (final BufferedInputStream inputStream = new BufferedInputStream(Files.newInputStream(path, options))) {
+        try (BufferedInputStream inputStream = new BufferedInputStream(Files.newInputStream(path, options))) {
             return updateDigest(digest, inputStream);
         }
     }

src/main/java/org/apache/commons/codec/digest/HmacUtils.java

@@ -971,7 +971,7 @@ public byte[] hmac(final ByteBuffer valueToDigest) {
      * @since 1.11
      */
     public byte[] hmac(final File valueToDigest) throws IOException {
-        try (final BufferedInputStream stream = new BufferedInputStream(new FileInputStream(valueToDigest))) {
+        try (BufferedInputStream stream = new BufferedInputStream(new FileInputStream(valueToDigest))) {
             return hmac(stream);
         }
     }

src/main/java/org/apache/commons/codec/language/ColognePhonetic.java

@@ -193,12 +193,12 @@ abstract static class CologneBuffer {
 
         protected int length;
 
-        public CologneBuffer(final char[] data) {
+        CologneBuffer(final char[] data) {
             this.data = data;
             this.length = data.length;
         }
 
-        public CologneBuffer(final int buffSize) {
+        CologneBuffer(final int buffSize) {
             this.data = new char[buffSize];
             this.length = 0;
         }
@@ -218,9 +218,10 @@ public String toString() {
             return new String(copyData(0, length));
         }
     }
+
     private final class CologneInputBuffer extends CologneBuffer {
 
-        public CologneInputBuffer(final char[] data) {
+        CologneInputBuffer(final char[] data) {
             super(data);
         }
 
@@ -245,11 +246,12 @@ public char removeNext() {
             return ch;
         }
     }
+
     private final class CologneOutputBuffer extends CologneBuffer {
 
         private char lastCode;
 
-        public CologneOutputBuffer(final int buffSize) {
+        CologneOutputBuffer(final int buffSize) {
             super(buffSize);
             lastCode = '/'; // impossible value
         }

src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java

@@ -224,7 +224,7 @@ public String toString() {
     private static final Map<Character, Character> FOLDINGS = new HashMap<>();
 
     static {
-        try (final Scanner scanner = new Scanner(Resources.getInputStream(RESOURCE_FILE), CharEncoding.UTF_8)) {
+        try (Scanner scanner = new Scanner(Resources.getInputStream(RESOURCE_FILE), CharEncoding.UTF_8)) {
             parseRules(scanner, RESOURCE_FILE, RULES, FOLDINGS);
         }
 

src/main/java/org/apache/commons/codec/language/bm/Lang.java

@@ -135,7 +135,7 @@ public static Lang instance(final NameType nameType) {
      */
     public static Lang loadFromResource(final String languageRulesResourceName, final Languages languages) {
         final List<LangRule> rules = new ArrayList<>();
-        try (final Scanner scanner = new Scanner(Resources.getInputStream(languageRulesResourceName),
+        try (Scanner scanner = new Scanner(Resources.getInputStream(languageRulesResourceName),
                 ResourceConstants.ENCODING)) {
             boolean inExtendedComment = false;
             while (scanner.hasNextLine()) {

src/main/java/org/apache/commons/codec/language/bm/Languages.java

@@ -251,7 +251,7 @@ public static Languages getInstance(final NameType nameType) {
     public static Languages getInstance(final String languagesResourceName) {
         // read languages list
         final Set<String> ls = new HashSet<>();
-        try (final Scanner lsScanner = new Scanner(Resources.getInputStream(languagesResourceName),
+        try (Scanner lsScanner = new Scanner(Resources.getInputStream(languagesResourceName),
                 ResourceConstants.ENCODING)) {
             boolean inExtendedComment = false;
             while (lsScanner.hasNextLine()) {

src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java

@@ -169,7 +169,7 @@ private static final class RulesApplication {
         private final int maxPhonemes;
         private boolean found;
 
-        public RulesApplication(final Map<String, List<Rule>> finalRules, final CharSequence input, final PhonemeBuilder phonemeBuilder, final int i,
+        RulesApplication(final Map<String, List<Rule>> finalRules, final CharSequence input, final PhonemeBuilder phonemeBuilder, final int i,
                 final int maxPhonemes) {
             Objects.requireNonNull(finalRules, "finalRules");
             this.finalRules = finalRules;

src/main/java/org/apache/commons/codec/language/bm/Rule.java

@@ -241,14 +241,14 @@ public interface RPattern {
 
                 final Languages ls = Languages.getInstance(s);
                 ls.getLanguages().forEach(l -> {
-                    try (final Scanner scanner = createScanner(s, rt, l)) {
+                    try (Scanner scanner = createScanner(s, rt, l)) {
                         rs.put(l, parseRules(scanner, createResourceName(s, rt, l)));
                     } catch (final IllegalStateException e) {
                         throw new IllegalStateException("Problem processing " + createResourceName(s, rt, l), e);
                     }
                 });
                 if (!rt.equals(RuleType.RULES)) {
-                    try (final Scanner scanner = createScanner(s, rt, "common")) {
+                    try (Scanner scanner = createScanner(s, rt, "common")) {
                         rs.put("common", parseRules(scanner, createResourceName(s, rt, "common")));
                     }
                 }
@@ -444,7 +444,7 @@ private static Map<String, List<Rule>> parseRules(final Scanner scanner, final S
                         throw new IllegalArgumentException("Malformed import statement '" + rawLine + "' in " +
                                                            location);
                     }
-                    try (final Scanner hashIncludeScanner = createScanner(incl)) {
+                    try (Scanner hashIncludeScanner = createScanner(incl)) {
                         lines.putAll(parseRules(hashIncludeScanner, location + "->" + incl));
                     }
                 } else {

src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java

@@ -281,7 +281,7 @@ public static final byte[] encodeQuotedPrintable(BitSet printable, final byte[]
      *            the buffer to write to
      * @return The number of bytes written to the {@code buffer}
      */
-    private static final int encodeQuotedPrintable(final int b, final ByteArrayOutputStream buffer) {
+    private static int encodeQuotedPrintable(final int b, final ByteArrayOutputStream buffer) {
         buffer.write(ESCAPE_CHAR);
         final char hex1 = Utils.hexDigit(b >> 4);
         final char hex2 = Utils.hexDigit(b);