Precompile and resuse x3 regular expression in

DaitchMokotoffSoundex.Rule

Author: garydgregory

src/changes/changes.xml

@@ -48,6 +48,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Remove -nouses directive from maven-bundle-plugin. OSGi package imports now state 'uses' definitions for package imports, this doesn't affect JPMS (from org.apache.commons:commons-parent:80).</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Refactor DigestUtils.updateDigest(MessageDigest, File) to use NIO.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory" issue="CODEC-328" >Clarify Javadoc for org.apache.commons.codec.digest.UnixCrypt.crypt(byte[],String).</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Precompile and resuse x3 regular expression in DaitchMokotoffSoundex.Rule.</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add HmacUtils.hmac(Path).</action>      
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add HmacUtils.hmacHex(Path).</action>      

src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java

@@ -25,6 +25,7 @@
 import java.util.Map;
 import java.util.Scanner;
 import java.util.Set;
+import java.util.regex.Pattern;
 
 import org.apache.commons.codec.CharEncoding;
 import org.apache.commons.codec.EncoderException;
@@ -160,6 +161,7 @@ public String toString() {
      * Inner class for storing rules.
      */
     private static final class Rule {
+        private static final Pattern PIPE = Pattern.compile("\\|");
         private final String pattern;
         private final String[] replacementAtStart;
         private final String[] replacementBeforeVowel;
@@ -168,9 +170,9 @@ private static final class Rule {
         private Rule(final String pattern, final String replacementAtStart, final String replacementBeforeVowel,
                 final String replacementDefault) {
             this.pattern = pattern;
-            this.replacementAtStart = replacementAtStart.split("\\|");
-            this.replacementBeforeVowel = replacementBeforeVowel.split("\\|");
-            this.replacementDefault = replacementDefault.split("\\|");
+            this.replacementAtStart = PIPE.split(replacementAtStart);
+            this.replacementBeforeVowel = PIPE.split(replacementBeforeVowel);
+            this.replacementDefault = PIPE.split(replacementDefault);
         }
 
         private int getPatternLength() {