Use JUnit 5 convention for class visibility

Author: garydgregory

src/test/java/org/apache/commons/collections4/ArrayUtilsTest.java

@@ -22,7 +22,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class ArrayUtilsTest {
+class ArrayUtilsTest {
 
     @Test
     void testContains() {

src/test/java/org/apache/commons/collections4/BagUtilsTest.java

@@ -37,7 +37,7 @@
 /**
  * Tests for BagUtils factory methods.
  */
-public class BagUtilsTest {
+class BagUtilsTest {
 
     protected Predicate<Object> truePredicate = TruePredicate.truePredicate();
     protected Transformer<Object, Object> nopTransformer = TransformerUtils.nopTransformer();

src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java

@@ -38,7 +38,7 @@
 /**
  * Tests the ClosureUtils class.
  */
-public class ClosureUtilsTest {
+class ClosureUtilsTest {
 
     static class MockClosure<T> implements Closure<T> {
         int count;

src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java

@@ -64,7 +64,7 @@
  * Tests for CollectionUtils.
  */
 @SuppressWarnings("boxing")
-public class CollectionUtilsTest extends MockTestCase {
+class CollectionUtilsTest extends MockTestCase {
 
     private static final Predicate<Number> EQUALS_TWO = input -> input.intValue() == 2;
 

src/test/java/org/apache/commons/collections4/ComparatorUtilsTest.java

@@ -27,7 +27,7 @@
 /**
  * Tests ComparatorUtils.
  */
-public class ComparatorUtilsTest {
+class ComparatorUtilsTest {
 
     @Test
     void testBooleanComparator() {

src/test/java/org/apache/commons/collections4/EnumerationUtilsTest.java

@@ -36,7 +36,7 @@
 /**
  * Tests EnumerationUtils.
  */
-public class EnumerationUtilsTest {
+class EnumerationUtilsTest {
 
     public static final String TO_LIST_FIXTURE = "this is a test";
 

src/test/java/org/apache/commons/collections4/FactoryUtilsTest.java

@@ -39,20 +39,25 @@
 public class FactoryUtilsTest {
 
     public static class Mock1 {
+
         private final int iVal;
+
         public Mock1(final int val) {
             iVal = val;
         }
+
         public Mock1(final Mock1 mock) {
             iVal = mock.iVal;
         }
+
         @Override
         public boolean equals(final Object obj) {
             if (obj instanceof Mock1 && iVal == ((Mock1) obj).iVal) {
                 return true;
             }
             return false;
         }
+
         @Override
         public int hashCode() { // please Findbugs
             return super.hashCode();
@@ -65,29 +70,35 @@ public static class Mock2 implements Serializable {
          */
         private static final long serialVersionUID = 4899282162482588924L;
         private final Object iVal;
-        public Mock2(final Object val) {
+
+        Mock2(final Object val) {
             iVal = val;
         }
+
         @Override
         public boolean equals(final Object obj) {
             if (obj instanceof Mock2 && iVal == ((Mock2) obj).iVal) {
                 return true;
             }
             return false;
         }
+
         @Override
         public int hashCode() { // please Findbugs
             return super.hashCode();
         }
     }
 
     public static class Mock3 {
+
         private static int cCounter;
         private final int iVal;
+
         public Mock3() {
             iVal = cCounter++;
         }
-        public int getValue() {
+
+        int getValue() {
             return iVal;
         }
     }

src/test/java/org/apache/commons/collections4/FluentIterableTest.java

@@ -40,7 +40,7 @@
 /**
  * Tests for FluentIterable.
  */
-public class FluentIterableTest {
+class FluentIterableTest {
 
     private static final Predicate<Number> EVEN = input -> input.intValue() % 2 == 0;
 

src/test/java/org/apache/commons/collections4/IterableUtilsTest.java

@@ -46,7 +46,7 @@
 /**
  * Tests for IterableUtils.
  */
-public class IterableUtilsTest {
+class IterableUtilsTest {
 
     private static final Predicate<Number> EQUALS_TWO = input -> input.intValue() == 2;
 

src/test/java/org/apache/commons/collections4/IteratorUtilsTest.java

@@ -66,7 +66,7 @@
 /**
  * Tests for IteratorUtils.
  */
-public class IteratorUtilsTest {
+class IteratorUtilsTest {
 
     /**
      * Collection of {@link Integer}s