Skip to content

Commit 9e7f5ac

Browse files
committed
[COLLECTIONS-777] Migrate to JUnit 5
Remove unused method
1 parent 474de2b commit 9e7f5ac

14 files changed

+0
-163
lines changed

src/test/java/org/apache/commons/collections4/BulkTest.java

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -66,43 +66,6 @@ public String getName() {
6666
return name;
6767
}
6868

69-
/**
70-
* Returns an array of test names to ignore.<P>
71-
*
72-
* If a test that's defined by this {@code BulkTest} or
73-
* by one of its bulk test methods has a name that's in the returned
74-
* array, then that simple test will not be executed.<P>
75-
*
76-
* A test's name is formed by taking the class name of the
77-
* root {@code BulkTest}, eliminating the package name, then
78-
* appending the names of any bulk test methods that were invoked
79-
* to get to the simple test, and then appending the simple test
80-
* method name. The method names are delimited by periods:
81-
*
82-
* <pre>
83-
* HashMapTest.bulkTestEntrySet.testClear
84-
* </pre>
85-
*
86-
* is the name of one of the simple tests defined in the sample classes
87-
* described above. If the sample {@code HashMapTest} class
88-
* included this method:
89-
*
90-
* <pre>
91-
* public String[] ignoredTests() {
92-
* return new String[] { "HashMapTest.bulkTestEntrySet.testClear" };
93-
* }
94-
* </pre>
95-
*
96-
* then the entry set's clear method wouldn't be tested, but the key
97-
* set's clear method would.
98-
*
99-
* @return an array of the names of tests to ignore, or null if
100-
* no tests should be ignored
101-
*/
102-
public String[] ignoredTests() {
103-
return null;
104-
}
105-
10669
/**
10770
* Returns the display name of this {@code BulkTest}.
10871
*

src/test/java/org/apache/commons/collections4/bidimap/DualHashBidiMapTest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,6 @@ protected int getIterationBehaviour() {
3131
return AbstractCollectionTest.UNORDERED;
3232
}
3333

34-
/**
35-
* Override to prevent infinite recursion of tests.
36-
*/
37-
@Override
38-
public String[] ignoredTests() {
39-
return new String[] { "DualHashBidiMapTest.bulkTestInverseMap.bulkTestInverseMap" };
40-
}
41-
4234
/**
4335
* {@inheritDoc}
4436
*/

src/test/java/org/apache/commons/collections4/bidimap/DualLinkedHashBidiMapTest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ public String getCompatibilityVersion() {
2929
return "4";
3030
}
3131

32-
/**
33-
* Override to prevent infinite recursion of tests.
34-
*/
35-
@Override
36-
public String[] ignoredTests() {
37-
return new String[] { "DualLinkedHashBidiMapTest.bulkTestInverseMap.bulkTestInverseMap" };
38-
}
39-
4032
/**
4133
* {@inheritDoc}
4234
*/

src/test/java/org/apache/commons/collections4/bidimap/DualTreeBidiMap2Test.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,6 @@ public String getCompatibilityVersion() {
6060
return "4.Test2";
6161
}
6262

63-
/**
64-
* Override to prevent infinite recursion of tests.
65-
*/
66-
@Override
67-
public String[] ignoredTests() {
68-
final String recursiveTest = "DualTreeBidiMap2Test.bulkTestInverseMap.bulkTestInverseMap";
69-
return new String[] { recursiveTest };
70-
}
71-
7263
@Override
7364
public boolean isAllowNullValueGet() {
7465
// TODO Is this a bug or a feature?

src/test/java/org/apache/commons/collections4/bidimap/DualTreeBidiMapTest.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,6 @@ public DualTreeBidiMapTest() {
2525
super();
2626
}
2727

28-
/**
29-
* Override to prevent infinite recursion of tests.
30-
*/
31-
@Override
32-
public String[] ignoredTests() {
33-
final String recursiveTest = "DualTreeBidiMapTest.bulkTestInverseMap.bulkTestInverseMap";
34-
return new String[] { recursiveTest };
35-
}
36-
3728
/**
3829
* {@inheritDoc}
3930
*/

src/test/java/org/apache/commons/collections4/bidimap/TreeBidiMapTest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,6 @@ public String getCompatibilityVersion() {
3030
return "4";
3131
}
3232

33-
/**
34-
* Override to prevent infinite recursion of tests.
35-
*/
36-
@Override
37-
public String[] ignoredTests() {
38-
return new String[] {"TreeBidiMapTest.bulkTestInverseMap.bulkTestInverseMap"};
39-
}
40-
4133
@Override
4234
public boolean isAllowNullKey() {
4335
return false;

src/test/java/org/apache/commons/collections4/bidimap/UnmodifiableBidiMapTest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,6 @@ protected int getIterationBehaviour() {
4141
return AbstractCollectionTest.UNORDERED;
4242
}
4343

44-
/**
45-
* Override to prevent infinite recursion of tests.
46-
*/
47-
@Override
48-
public String[] ignoredTests() {
49-
return new String[] {"UnmodifiableBidiMapTest.bulkTestInverseMap.bulkTestInverseMap"};
50-
}
51-
5244
@Override
5345
public boolean isPutAddSupported() {
5446
return false;

src/test/java/org/apache/commons/collections4/bidimap/UnmodifiableOrderedBidiMapTest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,6 @@
3232
*/
3333
public class UnmodifiableOrderedBidiMapTest<K extends Comparable<K>, V extends Comparable<V>> extends AbstractOrderedBidiMapTest<K, V> {
3434

35-
/**
36-
* Override to prevent infinite recursion of tests.
37-
*/
38-
@Override
39-
public String[] ignoredTests() {
40-
return new String[] {"UnmodifiableOrderedBidiMapTest.bulkTestInverseMap.bulkTestInverseMap"};
41-
}
42-
4335
@Override
4436
public boolean isAllowNullKey() {
4537
return false;

src/test/java/org/apache/commons/collections4/bidimap/UnmodifiableSortedBidiMapTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,6 @@ public UnmodifiableSortedBidiMapTest() {
3636
super();
3737
}
3838

39-
@Override
40-
public String[] ignoredTests() {
41-
// Override to prevent infinite recursion of tests.
42-
return new String[] {"UnmodifiableSortedBidiMapTest.bulkTestInverseMap.bulkTestInverseMap"};
43-
}
44-
4539
@Override
4640
public boolean isAllowNullKey() {
4741
return false;

src/test/java/org/apache/commons/collections4/list/CursorableLinkedListTest.java

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import static org.junit.jupiter.api.Assertions.assertThrows;
2626
import static org.junit.jupiter.api.Assertions.assertTrue;
2727

28-
import java.util.ArrayList;
2928
import java.util.ConcurrentModificationException;
3029
import java.util.HashSet;
3130
import java.util.Iterator;
@@ -50,33 +49,6 @@ public String getCompatibilityVersion() {
5049
return "4";
5150
}
5251

53-
/**
54-
* Ignore the serialization tests for sublists and sub-sublists.
55-
*
56-
* @return an array of sublist serialization test names
57-
*/
58-
@Override
59-
public String[] ignoredTests() {
60-
final ArrayList<String> list = new ArrayList<>();
61-
final String prefix = "CursorableLinkedListTest";
62-
final String bulk = ".bulkTestSubList";
63-
final String[] ignored = {
64-
".testEmptyListSerialization",
65-
".testFullListSerialization",
66-
".testEmptyListCompatibility",
67-
".testFullListCompatibility",
68-
".testSimpleSerialization",
69-
".testCanonicalEmptyCollectionExists",
70-
".testCanonicalFullCollectionExists",
71-
".testSerializeDeserializeThenCompare"
72-
};
73-
for (final String element : ignored) {
74-
list.add(prefix + bulk + element);
75-
list.add(prefix + bulk + bulk + element);
76-
}
77-
return list.toArray(ArrayUtils.EMPTY_STRING_ARRAY);
78-
}
79-
8052
@Override
8153
public CursorableLinkedList<E> makeObject() {
8254
return new CursorableLinkedList<>();

0 commit comments

Comments
 (0)