[COLLECTIONS-777] Migrate to JUnit 5

Remove JUnit 3 constructors

Author: garydgregory

src/test/java/org/apache/commons/collections4/AbstractArrayListTest.java

@@ -30,10 +30,6 @@
  */
 public abstract class AbstractArrayListTest<E> extends AbstractListTest<E> {
 
-    public AbstractArrayListTest(final String testName) {
-        super(testName);
-    }
-
     /**
      * {@inheritDoc}
      */

src/test/java/org/apache/commons/collections4/AbstractLinkedListTest.java

@@ -40,10 +40,6 @@
  */
 public abstract class AbstractLinkedListTest<T> extends AbstractListTest<T> {
 
-    public AbstractLinkedListTest(final String testName) {
-        super(testName);
-    }
-
     /**
      * Returns the {@link #collection} field cast to a {@link LinkedList}.
      *

src/test/java/org/apache/commons/collections4/AbstractObjectTest.java

@@ -49,15 +49,6 @@ public abstract class AbstractObjectTest extends BulkTest {
     /** Current major release for Collections */
     public static final int COLLECTIONS_MAJOR_VERSION = 4;
 
-    /**
-     * JUnit constructor.
-     *
-     * @param testName  the test class name
-     */
-    public AbstractObjectTest(final String testName) {
-        super(testName);
-    }
-
     protected String getCanonicalEmptyCollectionName(final Object object) {
         final StringBuilder retval = new StringBuilder();
         retval.append(TEST_DATA_PATH);

src/test/java/org/apache/commons/collections4/AbstractTreeMapTest.java

@@ -32,10 +32,6 @@
  */
 public abstract class AbstractTreeMapTest<K, V> extends AbstractMapTest<TreeMap<K, V>, K, V> {
 
-    public AbstractTreeMapTest(final String testName) {
-        super(testName);
-    }
-
     @Override
     public boolean isAllowNullKey() {
         return false;

src/test/java/org/apache/commons/collections4/ArrayStackTest.java

@@ -31,10 +31,6 @@
 @SuppressWarnings("deprecation") // we test a deprecated class
 public class ArrayStackTest<E> extends AbstractArrayListTest<E> {
 
-    public ArrayStackTest() {
-        super(ArrayStackTest.class.getSimpleName());
-    }
-
     @Override
     public String getCompatibilityVersion() {
         return "4";

src/test/java/org/apache/commons/collections4/BulkTest.java

@@ -16,21 +16,18 @@
  */
 package org.apache.commons.collections4;
 
-import junit.framework.TestCase;
-import junit.framework.TestSuite;
-
 /**
- * A {@link TestCase} that can define both simple and bulk test methods.
+ * A {@code TestCase} that can define both simple and bulk test methods.
  * <p>
  * A <em>simple test method</em> is the type of test traditionally
- * supplied by {@link TestCase}.  To define a simple test, create a public
+ * supplied by {@code TestCase}.  To define a simple test, create a public
  * no-argument method whose name starts with "test".  You can specify
  * the name of simple test in the constructor of {@code BulkTest};
- * a subsequent call to {@link TestCase#run} will run that simple test.
+ * a subsequent call to {@code TestCase#run} will run that simple test.
  * <p>
  * A <em>bulk test method</em>, on the other hand, returns a new instance
  * of {@code BulkTest}, which can itself define new simple and bulk
- * test methods.  By using the {@link #makeSuite} method, you can
+ * test methods.  By using the {@code #makeSuite} method, you can
  * automatically create a hierarchical suite of tests and child bulk tests.
  * <p>
  * For instance, consider the following two classes:
@@ -121,11 +118,11 @@
  *  A subclass can override a superclass's bulk test by
  *  returning {@code null} from the bulk test method.  If you only
  *  want to override specific simple tests within a bulk test, use the
- *  {@link #ignoredTests} method.<P>
+ *  {@code #ignoredTests} method.<P>
  *
  *  Note that if you want to use the bulk test methods, you <em>must</em>
- *  define your {@code suite()} method to use {@link #makeSuite}.
- *  The ordinary {@link TestSuite} constructor doesn't know how to
+ *  define your {@code suite()} method to use {@code #makeSuite}.
+ *  The ordinary {@code TestSuite} constructor doesn't know how to
  *  interpret bulk test methods.
  */
 public class BulkTest implements Cloneable {
@@ -160,11 +157,9 @@ public class BulkTest implements Cloneable {
     /**
      *  Constructs a new {@code BulkTest} instance that will run the
      *  specified simple test.
-     *
-     *  @param name  the name of the simple test method to run
      */
-    public BulkTest(final String name) {
-        this.name = name;
+    public BulkTest() {
+        this.name = getClass().getSimpleName();
         this.verboseName = getClass().getName();
     }
 

src/test/java/org/apache/commons/collections4/bag/AbstractBagTest.java

@@ -39,7 +39,6 @@
 import org.apache.commons.collections4.collection.AbstractCollectionTest;
 import org.apache.commons.collections4.set.AbstractSetTest;
 import org.apache.commons.lang3.ArrayUtils;
-import org.apache.commons.lang3.StringUtils;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -71,10 +70,6 @@ public abstract class AbstractBagTest<T> extends AbstractCollectionTest<T> {
 
     public class TestBagUniqueSet extends AbstractSetTest<T> {
 
-        public TestBagUniqueSet() {
-            super(StringUtils.EMPTY);
-        }
-
         @Override
         public T[] getFullElements() {
             return AbstractBagTest.this.getFullElements();
@@ -142,11 +137,8 @@ public void verify() {
 
     /**
      * JUnit constructor.
-     *
-     * @param testName  the test class name
      */
-    public AbstractBagTest(final String testName) {
-        super(testName);
+    public AbstractBagTest() {
     }
 
     /**

src/test/java/org/apache/commons/collections4/bag/AbstractSortedBagTest.java

@@ -29,10 +29,6 @@
  */
 public abstract class AbstractSortedBagTest<T> extends AbstractBagTest<T> {
 
-    public AbstractSortedBagTest(final String testName) {
-        super(testName);
-    }
-
     /**
      * Returns the {@link #collection} field cast to a {@link SortedBag}.
      *

src/test/java/org/apache/commons/collections4/bag/CollectionBagTest.java

@@ -41,13 +41,6 @@
  */
 public class CollectionBagTest<T> extends AbstractCollectionTest<T> {
 
-    /**
-     * JUnit constructor.
-     */
-    public CollectionBagTest() {
-        super(CollectionBagTest.class.getSimpleName());
-    }
-
     @Override
     public String getCompatibilityVersion() {
         return "4";

src/test/java/org/apache/commons/collections4/bag/CollectionSortedBagTest.java

@@ -37,13 +37,6 @@
  */
 public class CollectionSortedBagTest<T> extends AbstractCollectionTest<T> {
 
-    /**
-     * JUnit constructor.
-     */
-    public CollectionSortedBagTest() {
-        super(CollectionSortedBagTest.class.getSimpleName());
-    }
-
     @Override
     public String getCompatibilityVersion() {
         return "4";