org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceEntry.toReference(ReferenceStrength,

garydgregory · garydgregory · commit b01ed8d1c7e5 · 2025-04-29T08:18:53.000-04:00
T, int) now throws IllegalArgumentException instead of Error
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -24,6 +24,7 @@
   <body>
   <release version="4.5.1" date="YYYY-MM-DD" description="This is a feature and maintenance release. Java 8 or later is required.">
     <!-- FIX -->
+    <action type="fix" dev="ggregory" due-to="Gary Gregory">org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceEntry.toReference(ReferenceStrength, T, int) now throws IllegalArgumentException instead of Error</action>
     <!-- ADD -->
     <!-- UPDATE -->
   </release>
diff --git a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
@@ -368,7 +368,7 @@ protected <T> Object toReference(final ReferenceStrength type, final T referent,
             default:
                 break;
             }
-            throw new Error();
+            throw new IllegalArgumentException(type.toString());
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,7 @@ protected <T> Object toReference(final ReferenceStrength type, final T referent,`
`368`	`368`	`default:`
`369`	`369`	`break;`
`370`	`370`	`}`
`371`		`- throw new Error();`
	`371`	`+ throw new IllegalArgumentException(type.toString());`
`372`	`372`	`}`
`373`	`373`	`}`
`374`	`374`