[COLLECTIONS-874] MapUtils.getLongValue(Map, K, Function) returns a byte

instead of a long

Author: garydgregory

src/changes/changes.xml

@@ -29,6 +29,7 @@
     <action type="fix" dev="ggregory" due-to="Eric Hubert, Gary Gregory">Remove deprecation annotation of org.apache.commons.collections4.Predicate; this will be deprecated in 5.0 in favor of java.util.function.Predicate.</action>
     <action type="fix" dev="ggregory" due-to="Eric Hubert, Gary Gregory">Remove deprecation annotation of org.apache.commons.collections4.Transformer; this will be deprecated in 5.0 in favor of java.util.function.Function.</action>
     <action type="fix" dev="ggregory" due-to="Eric Hubert, Gary Gregory">Remove deprecation annotation of org.apache.commons.collections4.Closure; this will be deprecated in 5.0 in favor of java.util.function.Consumer.</action>
+    <action type="fix" dev="ggregory" due-to="Sebastian Götz, Gary Gregory" issue="COLLECTIONS-874">MapUtils.getLongValue(Map, K, Function) returns a byte instead of a long.</action>
     <!-- ADD -->
     <!-- UPDATE -->
     <action type="update" dev="ggregory" due-to="Gary Gregory, Dependabot">Bump org.apache.commons:commons-parent from 81 to 83 #612.</action>

src/main/java/org/apache/commons/collections4/MapUtils.java

@@ -838,7 +838,7 @@ public static <K> long getLongValue(final Map<? super K, ?> map, final K key) {
      */
     public static <K> long getLongValue(final Map<? super K, ?> map, final K key,
             final Function<K, Long> defaultFunction) {
-        return applyDefaultFunction(map, key, MapUtils::getLong, defaultFunction, 0L).byteValue();
+        return applyDefaultFunction(map, key, MapUtils::getLong, defaultFunction, 0L).longValue();
     }
 
     /**

src/test/java/org/apache/commons/collections4/MapUtilsTest.java

@@ -499,6 +499,8 @@ public void testGetLongValue() {
         assertEquals(2.0, MapUtils.getLongValue(in, "key"), 0);
         assertEquals(1, MapUtils.getLongValue(in, "noKey", 1L), 0);
         assertEquals(1, MapUtils.getLongValue(in, "noKey", key -> 1L), 0);
+        assertEquals(Long.MIN_VALUE, MapUtils.getLongValue(in, "noKey", key -> Long.MIN_VALUE), 0);
+        assertEquals(Long.MAX_VALUE, MapUtils.getLongValue(in, "noKey", key -> Long.MAX_VALUE), 0);
         assertEquals(0, MapUtils.getLongValue(in, "noKey"), 0);
         assertEquals(2.0, MapUtils.getLong(in, "key", 0L), 0);
         assertEquals(1, MapUtils.getLong(in, "noKey", 1L), 0);