Skip to content

Commit ddef8cd

Browse files
committed
Bump org.apache.commons:commons-parent from 85 to 87
- Fix UselessOverridingMethod in org.apache.commons.collections4.properties.PropertiesFactory
1 parent 923cd00 commit ddef8cd

File tree

3 files changed

+3
-16
lines changed

3 files changed

+3
-16
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<parent>
2020
<groupId>org.apache.commons</groupId>
2121
<artifactId>commons-parent</artifactId>
22-
<version>84</version>
22+
<version>87</version>
2323
</parent>
2424
<modelVersion>4.0.0</modelVersion>
2525
<artifactId>commons-collections4</artifactId>

src/changes/changes.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,11 @@
3434
<action type="fix" dev="ggregory" due-to="Gary Gregory">Fix exception message in org.apache.commons.collections4.iterators.UnmodifiableIterator.remove() to match java.util.Iterator.remove().</action>
3535
<action type="fix" dev="pkarwasz" due-to="Piotr P. Karwasz, Joerg Budischewski" issue="COLLECTIONS-838">Calling SetUtils.union on multiple instances of SetView causes JVM to hang</action>
3636
<action type="fix" dev="pkarwasz" due-to="Piotr P. Karwasz, Joerg Budischewski" issue="COLLECTIONS-722">Improve IteratorUtils.chainedIterator() performance.</action>
37+
<action type="fix" dev="ggregory" due-to="Gary Gregory, PMD">Fix UselessOverridingMethod in org.apache.commons.collections4.properties.PropertiesFactory.</action>
3738
<!-- ADD -->
3839
<action type="add" dev="ggregory" due-to="Gary Gregory">Add generics to UnmodifiableIterator for the wrapped type.</action>
3940
<!-- UPDATE -->
40-
<action type="update" dev="ggregory" due-to="Gary Gregory, Dependabot">Bump org.apache.commons:commons-parent from 81 to 84 #612.</action>
41+
<action type="update" dev="ggregory" due-to="Gary Gregory, Dependabot">Bump org.apache.commons:commons-parent from 81 to 87 #612.</action>
4142
<action type="update" dev="ggregory" due-to="Gary Gregory">Bump com.google.guava:guava-testlib from 33.3.1-jre to 33.4.8-jre.</action>
4243
<action type="update" dev="ggregory" due-to="Gary Gregory">Bump PMD from 7.8.0 to 7.13.0 (now inherited from parent POM).</action>
4344
<action type="update" dev="ggregory" due-to="Gary Gregory">Bump org.easymock:easymock from 5.5.0 to 5.6.0 #617.</action>

src/main/java/org/apache/commons/collections4/properties/PropertiesFactory.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
import java.io.IOException;
2121
import java.io.InputStream;
22-
import java.io.OutputStream;
2322
import java.io.Reader;
2423
import java.util.Collection;
2524
import java.util.Collections;
@@ -254,13 +253,6 @@ public synchronized void replaceAll(
254253
throw new UnsupportedOperationException();
255254
}
256255

257-
@SuppressWarnings("deprecation")
258-
@Override
259-
public void save(final OutputStream out, final String comments) {
260-
// Implement as super
261-
super.save(out, comments);
262-
}
263-
264256
@Override
265257
public synchronized Object setProperty(final String key, final String value) {
266258
Objects.requireNonNull(key);
@@ -278,12 +270,6 @@ public Set<String> stringPropertyNames() {
278270
return Collections.emptySet();
279271
}
280272

281-
@Override
282-
public synchronized String toString() {
283-
// Implement as super
284-
return super.toString();
285-
}
286-
287273
@Override
288274
public Collection<Object> values() {
289275
return Collections.emptyList();

0 commit comments

Comments
 (0)