Skip to content

Commit b2de056

Browse files
committed
Use JUnit 5 to convert String to Charset
1 parent 97baeaa commit b2de056

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/test/java/org/apache/commons/compress/compressors/gzip/GzipParametersTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import static org.junit.jupiter.api.Assertions.assertThrows;
2525
import static org.junit.jupiter.api.Assertions.assertTrue;
2626

27+
import java.nio.charset.Charset;
2728
import java.util.zip.Deflater;
2829

2930
import org.apache.commons.io.Charsets;
@@ -53,10 +54,10 @@ public void testDeflaterStrategy() {
5354
"UTF-16BE , helloworld, false"
5455
})
5556
//@formatter:on
56-
public void testIllegalCommentOrFileName(final String charsetName, final String text) {
57+
public void testIllegalCommentOrFileName(final Charset charset, final String text) {
5758
final GzipParameters gzipParameters = new GzipParameters();
5859
// null resets to default value
59-
gzipParameters.setFileNameCharset(Charsets.toCharset(charsetName, null));
60+
gzipParameters.setFileNameCharset(charset);
6061
assertThrows(IllegalArgumentException.class, () -> gzipParameters.setComment(text));
6162
assertNull(gzipParameters.getComment());
6263
assertThrows(IllegalArgumentException.class, () -> gzipParameters.setFilename(text));
@@ -76,10 +77,10 @@ public void testIllegalCommentOrFileName(final String charsetName, final String
7677
"UTF-8 , helloéworld"
7778
})
7879
//@formatter:on
79-
public void testLegalCommentOrFileName(final String charsetName, final String text) {
80+
public void testLegalCommentOrFileName(final Charset charset, final String text) {
8081
final GzipParameters gzipParameters = new GzipParameters();
8182
// null resets to default value
82-
gzipParameters.setFileNameCharset(Charsets.toCharset(charsetName, null));
83+
gzipParameters.setFileNameCharset(charset);
8384
gzipParameters.setComment(text);
8485
assertEquals(text, gzipParameters.getComment());
8586
gzipParameters.setFilename(text);

0 commit comments

Comments
 (0)