CSV-320: Remove Spotbugs Dependency and use exclude-filter instead (#564)

Removes the Spotbugs dependency that introduces a compile time dependency to CsvPrinter.

Author: bjrke

pom.xml

@@ -68,12 +68,6 @@
       <version>${commons.jmh.version}</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>com.github.spotbugs</groupId>
-      <artifactId>spotbugs-annotations</artifactId>
-      <version>${commons.spotbugs.impl.version}</version>
-      <optional>true</optional>
-    </dependency>
   </dependencies>
   <scm>
     <connection>scm:git:https://gitbox.apache.org/repos/asf/commons-csv.git</connection>

src/main/java/org/apache/commons/csv/CSVPrinter.java

@@ -40,8 +40,6 @@
 
 import org.apache.commons.io.function.IOStream;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 /**
  * Prints values in a {@link CSVFormat CSV format}.
  *
@@ -153,7 +151,6 @@ public void close(final boolean flush) throws IOException {
      * @throws IOException
      *             If an I/O error occurs
      */
-    @SuppressFBWarnings(value = "AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE", justification = "https://github.com/spotbugs/spotbugs/issues/3428")
     private void endOfRecord() throws IOException {
         println();
         recordCount++;

src/site/resources/spotbugs/spotbugs-exclude-filter.xml

@@ -54,5 +54,12 @@
     <Method name="values" />
     <Bug pattern="EI_EXPOSE_REP"/>
   </Match>
+
+  <!-- https://github.com/spotbugs/spotbugs/issues/3428 -->
+  <Match>
+    <Class name="org.apache.commons.csv.CSVPrinter" />
+    <Method name="endOfRecord" />
+    <Bug pattern="AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE" />
+  </Match>
 
 </FindBugsFilter>