Skip to content

Commit 0a71344

Browse files
committed
Fix test fixtures
1 parent 526b315 commit 0a71344

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/test/java/org/apache/commons/io/FileUtilsTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2815,9 +2815,9 @@ public void testReadFileToString_IOExceptionOnPosixFileSystem() throws Exception
28152815
@Test
28162816
public void testReadFileToStringWithDefaultEncoding() throws Exception {
28172817
final File file = new File(tempDirFile, "read.obj");
2818-
final String fixture = "Hello \u1234";
2818+
// Don't use non-ASCII in this test fixture because this test uses the default platform encoding.
2819+
final String fixture = "Hello 1234";
28192820
Files.write(file.toPath(), fixture.getBytes());
2820-
28212821
assertEquals(fixture, FileUtils.readFileToString(file));
28222822
}
28232823

@@ -3506,7 +3506,7 @@ public void testWriteStringToFileIntoSymlinkedDir() throws Exception {
35063506
final Path symlinkDir = createTempSymbolicLinkedRelativeDir().getLeft();
35073507
final File file = symlinkDir.resolve("file").toFile();
35083508
FileUtils.writeStringToFile(file, "Hello \u1234", StandardCharsets.UTF_8);
3509-
final byte[] text = "Hello \u1234".getBytes();
3509+
final byte[] text = "Hello \u1234".getBytes(StandardCharsets.UTF_8);
35103510
TestUtils.assertEqualContent(text, file);
35113511
}
35123512

src/test/java/org/apache/commons/io/IOUtilsTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,8 @@ public void testReadLines_Reader() throws Exception {
10851085
final File file = TestUtils.newFile(temporaryFolder, "lines.txt");
10861086
Reader in = null;
10871087
try {
1088-
final String[] data = {"hello", "\u1234", "", "this is", "some text"};
1088+
// Don't use non-ASCII in this test fixture because this test uses the default platform encoding.
1089+
final String[] data = {"hello", "1234", "", "this is", "some text"};
10891090
TestUtils.createLineFileUtf8(file, data);
10901091
in = new InputStreamReader(Files.newInputStream(file.toPath()));
10911092
final List<String> lines = IOUtils.readLines(in);

0 commit comments

Comments
 (0)