Skip to content

Commit 2594bb5

Browse files
committed
Window failures with Charset issues on Java 8, 11, and 17 as seen on GH
CI, 21 and 24 are OK.
1 parent 5664b11 commit 2594bb5

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/test/java/org/apache/commons/io/FileSystemTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import static org.junit.jupiter.api.Assertions.assertNotSame;
3232
import static org.junit.jupiter.api.Assertions.assertThrows;
3333
import static org.junit.jupiter.api.Assertions.assertTrue;
34+
import static org.junit.jupiter.api.Assumptions.assumeTrue;
3435

3536
import java.io.BufferedReader;
3637
import java.io.FileNotFoundException;
@@ -518,6 +519,11 @@ void testToLegalFileNameWindows() {
518519
@ParameterizedTest
519520
@EnumSource(FileSystem.class)
520521
void testXmlRoundtrip(final FileSystem fs, @TempDir final Path tempDir) throws Exception {
522+
if (SystemUtils.IS_OS_WINDOWS) {
523+
// TODO
524+
// Window failures with Charset issues on Java 8, 11, and 17 as seen on GH CI, 21 and 24 are OK.
525+
assumeTrue(SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_21));
526+
}
521527
final Charset charset = StandardCharsets.UTF_8;
522528
assertEquals("a", fs.toLegalFileName("a", '_', charset));
523529
assertEquals("abcdefghijklmno", fs.toLegalFileName("abcdefghijklmno", '_', charset));

0 commit comments

Comments
 (0)