Use final

Author: garydgregory

src/main/java/org/apache/commons/io/IOUtils.java

@@ -198,7 +198,7 @@ static char[] getScratchCharArray() {
          *
          * @param array the byte array to release.
          */
-        static void releaseScratchByteArray(byte[] array) {
+        static void releaseScratchByteArray(final byte[] array) {
             final Object[] holder = SCRATCH_BYTE_BUFFER_HOLDER.get();
             if (array == holder[1]) {
                 Arrays.fill(array, (byte) 0);
@@ -211,7 +211,7 @@ static void releaseScratchByteArray(byte[] array) {
          *
          * @param array the char array to release.
          */
-        static void releaseScratchCharArray(char[] array) {
+        static void releaseScratchCharArray(final char[] array) {
             final Object[] holder = SCRATCH_CHAR_BUFFER_HOLDER.get();
             if (array == holder[1]) {
                 Arrays.fill(array, (char) 0);

src/test/java/org/apache/commons/io/FileUtilsTest.java

@@ -170,7 +170,7 @@ List<File> list(final File startDirectory) throws IOException {
      */
     private static final ListDirectoryWalker LIST_WALKER = new ListDirectoryWalker();
 
-    private static void setDosReadOnly(Path p, boolean readOnly) throws IOException {
+    private static void setDosReadOnly(final Path p, final boolean readOnly) throws IOException {
         if (Files.getFileStore(p).supportsFileAttributeView(DosFileAttributeView.class)) {
             Files.setAttribute(p, "dos:readonly", readOnly, LinkOption.NOFOLLOW_LINKS);
         }

src/test/java/org/apache/commons/io/IOUtilsConcurrentTest.java

@@ -48,7 +48,7 @@ private static class ChecksumReader extends Reader {
         private final long expectedChecksumValue;
         private final Reader reader;
 
-        ChecksumReader(Reader reader, long expectedChecksumValue) {
+        ChecksumReader(final Reader reader, final long expectedChecksumValue) {
             this.reader = reader;
             this.checksum = new CRC32();
             this.expectedChecksumValue = expectedChecksumValue;
@@ -69,7 +69,7 @@ public int read() throws IOException {
         }
 
         @Override
-        public int read(char[] cbuf, int off, int len) throws IOException {
+        public int read(final char[] cbuf, final int off, final int len) throws IOException {
             final int n = reader.read(cbuf, off, len);
             if (n > 0) {
                 final byte[] bytes = new String(cbuf, off, n).getBytes(Charset.defaultCharset());
@@ -171,7 +171,7 @@ static Stream<IOConsumer<Reader>> testConcurrentReaderTasks() {
 
     @ParameterizedTest
     @MethodSource
-    void testConcurrentInputStreamTasks(IOConsumer<InputStream> consumer) throws InterruptedException {
+    void testConcurrentInputStreamTasks(final IOConsumer<InputStream> consumer) throws InterruptedException {
         final ExecutorService threadPool = Executors.newFixedThreadPool(THREAD_COUNT);
         try {
             final List<Future<Void>> futures = IntStream.range(0, THREAD_COUNT * RUNS_PER_THREAD)
@@ -194,7 +194,7 @@ void testConcurrentInputStreamTasks(IOConsumer<InputStream> consumer) throws Int
 
     @ParameterizedTest
     @MethodSource
-    void testConcurrentReaderTasks(IOConsumer<Reader> consumer) throws InterruptedException {
+    void testConcurrentReaderTasks(final IOConsumer<Reader> consumer) throws InterruptedException {
         final ExecutorService threadPool = Executors.newFixedThreadPool(THREAD_COUNT);
         try {
             final List<Future<Void>> futures = IntStream.range(0, THREAD_COUNT * RUNS_PER_THREAD)

src/test/java/org/apache/commons/io/IOUtilsTest.java

@@ -421,7 +421,7 @@ void testByteArrayWithNegativeSize() {
 
     @ParameterizedTest
     @MethodSource
-    void testCheckFromIndexSizeInvalidCases(int off, int len, int arrayLength) {
+    void testCheckFromIndexSizeInvalidCases(final int off, final int len, final int arrayLength) {
         final IndexOutOfBoundsException ex = assertThrows(IndexOutOfBoundsException.class, () -> IOUtils.checkFromIndexSize(off, len, arrayLength));
         assertTrue(ex.getMessage().contains(String.valueOf(off)));
         assertTrue(ex.getMessage().contains(String.valueOf(len)));
@@ -431,7 +431,7 @@ void testCheckFromIndexSizeInvalidCases(int off, int len, int arrayLength) {
             final IndexOutOfBoundsException jreEx = assertThrows(IndexOutOfBoundsException.class, () -> {
                 try {
                     Objects.class.getDeclaredMethod("checkFromIndexSize", int.class, int.class, int.class).invoke(null, off, len, arrayLength);
-                } catch (InvocationTargetException ite) {
+                } catch (final InvocationTargetException ite) {
                     throw ite.getTargetException();
                 }
             });
@@ -441,13 +441,13 @@ void testCheckFromIndexSizeInvalidCases(int off, int len, int arrayLength) {
 
     @ParameterizedTest
     @MethodSource
-    void testCheckFromIndexSizeValidCases(int off, int len, int arrayLength) {
+    void testCheckFromIndexSizeValidCases(final int off, final int len, final int arrayLength) {
         assertDoesNotThrow(() -> IOUtils.checkFromIndexSize(off, len, arrayLength));
     }
 
     @ParameterizedTest
     @MethodSource
-    void testCheckFromToIndexInvalidCases(int from, int to, int arrayLength) {
+    void testCheckFromToIndexInvalidCases(final int from, final int to, final int arrayLength) {
         final IndexOutOfBoundsException ex = assertThrows(IndexOutOfBoundsException.class, () -> IOUtils.checkFromToIndex(from, to, arrayLength));
         assertTrue(ex.getMessage().contains(String.valueOf(from)));
         assertTrue(ex.getMessage().contains(String.valueOf(to)));
@@ -457,7 +457,7 @@ void testCheckFromToIndexInvalidCases(int from, int to, int arrayLength) {
             final IndexOutOfBoundsException jreEx = assertThrows(IndexOutOfBoundsException.class, () -> {
                 try {
                     Objects.class.getDeclaredMethod("checkFromToIndex", int.class, int.class, int.class).invoke(null, from, to, arrayLength);
-                } catch (InvocationTargetException ite) {
+                } catch (final InvocationTargetException ite) {
                     throw ite.getTargetException();
                 }
             });
@@ -467,7 +467,7 @@ void testCheckFromToIndexInvalidCases(int from, int to, int arrayLength) {
 
     @ParameterizedTest
     @MethodSource
-    void testCheckFromToIndexValidCases(int from, int to, int arrayLength) {
+    void testCheckFromToIndexValidCases(final int from, final int to, final int arrayLength) {
         assertDoesNotThrow(() -> IOUtils.checkFromToIndex(from, to, arrayLength));
     }
 
@@ -1168,7 +1168,8 @@ void testCopyLarge_SkipWithInvalidOffset() throws IOException {
 
     @ParameterizedTest
     @MethodSource("invalidRead_InputStream_Offset_ArgumentsProvider")
-    void testRead_InputStream_Offset_ArgumentsValidation(InputStream input, byte[] b, int off, int len, Class<? extends Throwable> expected) {
+    void testRead_InputStream_Offset_ArgumentsValidation(final InputStream input, final byte[] b, final int off, final int len,
+            final Class<? extends Throwable> expected) {
         assertThrows(expected, () -> IOUtils.read(input, b, off, len));
     }
 
@@ -1223,7 +1224,8 @@ void testReadFully_InputStream_Offset() throws Exception {
 
     @ParameterizedTest
     @MethodSource("invalidRead_InputStream_Offset_ArgumentsProvider")
-    void testReadFully_InputStream_Offset_ArgumentsValidation(InputStream input, byte[] b, int off, int len, Class<? extends Throwable> expected) {
+    void testReadFully_InputStream_Offset_ArgumentsValidation(final InputStream input, final byte[] b, final int off, final int len,
+            final Class<? extends Throwable> expected) {
         assertThrows(expected, () -> IOUtils.read(input, b, off, len));
     }