Reuse StringUtils.isNotEmpty()

garydgregory · garydgregory · commit 10136c7e7646 · 2025-11-16T10:29:32.000-05:00
diff --git a/src/main/java/org/apache/commons/jxpath/JXPathContextFactory.java b/src/main/java/org/apache/commons/jxpath/JXPathContextFactory.java
@@ -27,6 +27,7 @@
 import java.util.Properties;
 
 import org.apache.commons.jxpath.util.ClassLoaderUtil;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.SystemProperties;
 
 /**
@@ -109,7 +110,7 @@ private static String findFactory(final String property, final String defaultFac
                     }
                     try (BufferedReader rd = new BufferedReader(new InputStreamReader(is, "UTF-8"))) {
                         final String factory = rd.readLine();
-                        if (factory != null && !"".equals(factory)) {
+                        if (StringUtils.isNotEmpty(factory)) {
                             if (debug) {
                                 System.err.println("JXPath: loaded from services: " + factory);
                             }

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@`
`27`	`27`	`import java.util.Properties;`
`28`	`28`
`29`	`29`	`import org.apache.commons.jxpath.util.ClassLoaderUtil;`
	`30`	`+import org.apache.commons.lang3.StringUtils;`
`30`	`31`	`import org.apache.commons.lang3.SystemProperties;`
`31`	`32`
`32`	`33`	`/**`
`@@ -109,7 +110,7 @@ private static String findFactory(final String property, final String defaultFac`
`109`	`110`	`}`
`110`	`111`	`try (BufferedReader rd = new BufferedReader(new InputStreamReader(is, "UTF-8"))) {`
`111`	`112`	`final String factory = rd.readLine();`
`112`		`- if (factory != null && !"".equals(factory)) {`
	`113`	`+ if (StringUtils.isNotEmpty(factory)) {`
`113`	`114`	`if (debug) {`
`114`	`115`	`System.err.println("JXPath: loaded from services: " + factory);`
`115`	`116`	`}`