Use SystemProperties instead of magic strings

Author: garydgregory

src/main/java/org/apache/commons/jxpath/JXPathContextFactory.java

@@ -69,20 +69,16 @@ public abstract class JXPathContextFactory {
      */
     private static String findFactory(final String property, final String defaultFactory) {
         // Use the factory ID system property first
-        try {
-            final String systemProp = System.getProperty(property);
-            if (systemProp != null) {
-                if (debug) {
-                    System.err.println("JXPath: found system property" + systemProp);
-                }
-                return systemProp;
+        final String systemProp = SystemProperties.getProperty(property);
+        if (systemProp != null) {
+            if (debug) {
+                System.err.println("JXPath: found system property" + systemProp);
             }
-        } catch (final SecurityException ignore) { // NOPMD
-            // Ignore
+            return systemProp;
         }
         // try to read from $java.home/lib/xml.properties
         try {
-            final Path javaHome = Paths.get(System.getProperty("java.home"));
+            final Path javaHome = Paths.get(SystemProperties.getJavaHome());
             final Path configFile = javaHome.resolve(Paths.get("lib", "jxpath.properties"));
             if (Files.exists(configFile)) {
                 final Properties props = new Properties();

src/main/java/org/apache/commons/jxpath/ri/parser/ParseException.java

@@ -18,6 +18,8 @@
 
 package org.apache.commons.jxpath.ri.parser;
 
+import org.apache.commons.lang3.SystemProperties;
+
 /**
  * This exception is thrown when parse errors are encountered. You can explicitly create objects of this exception type by calling the method
  * generateParseException in the generated parser.
@@ -52,7 +54,7 @@ public class ParseException extends Exception {
     /**
      * The end of line string for this machine.
      */
-    protected String eol = System.getProperty("line.separator", "\n");
+    protected String eol = SystemProperties.getLineSeparator(() -> "\n");
 
     /**
      * The following constructors are for use by you for whatever purpose you can think of. Constructing the exception in this manner makes the exception behave