JXPathException now reuses its superclass' Throwable cause

Author: garydgregory

src/changes/changes.xml

@@ -116,6 +116,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action dev="ggregory" type="fix" due-to="Gary Gregory">Deprecate ValueUtils.ValueUtils().</action>
       <action dev="ggregory" type="fix" due-to="Gary Gregory">PageScopeContext.getAttributeNames() is now typed with generics.</action>
       <action dev="ggregory" type="fix" due-to="Gary Gregory">Functions.getUsedNamespaces() is now typed with generics.</action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory">JXPathException now reuses its superclass' Throwable cause.</action>
       <!-- ADD -->
       <action issue="JXPATH-123" dev="mbenson" type="add">
         XPath function "ends-with" is not implemented (although "starts-with" is).

src/main/java/org/apache/commons/jxpath/JXPathException.java

@@ -23,14 +23,11 @@
 public class JXPathException extends RuntimeException {
 
     private static final long serialVersionUID = 4306409701468017766L;
-    /** @serial */
-    private final Throwable exception;
 
     /**
      * Create a new {@code JXPathException} with no detail mesage.
      */
     public JXPathException() {
-        this.exception = null;
     }
 
     /**
@@ -40,38 +37,25 @@ public JXPathException() {
      */
     public JXPathException(final String msg) {
         super(msg);
-        this.exception = null;
     }
 
     /**
      * Create a new {@code JXPathException} with the given {@code Exception} base cause and detail message.
      *
      * @param msg The detail message.
-     * @param e   The exception to be encapsulated in a JXPathException
+     * @param cause   The exception to be encapsulated in a JXPathException
      */
-    public JXPathException(final String msg, final Throwable e) {
-        super(msg);
-        this.exception = e;
+    public JXPathException(final String msg, final Throwable cause) {
+        super(msg, cause);
     }
 
     /**
      * Create a new {@code JXPathException} with a given {@code Throwable} base cause of the error.
      *
-     * @param e The exception to be encapsulated in a JXPathException.
-     */
-    public JXPathException(final Throwable e) {
-        super(e.toString());
-        this.exception = e;
-    }
-
-    /**
-     * Same as {@link #getException() getException()}
-     * 
-     * @return The encapsulated exception, or null if there is none.
+     * @param cause The exception to be encapsulated in a JXPathException.
      */
-    @Override
-    public Throwable getCause() {
-        return exception;
+    public JXPathException(final Throwable cause) {
+        super(cause.toString());
     }
 
     /**
@@ -80,27 +64,7 @@ public Throwable getCause() {
      * @return The encapsulated exception, or null if there is none.
      */
     public Throwable getException() {
-        return exception;
+        return super.getCause();
     }
 
-    /**
-     * Gets the message (if any) for this error . If there is no message for the exception and there is an encapsulated exception then the message of that
-     * exception will be returned.
-     *
-     * @return The error message.
-     */
-    @Override
-    public String getMessage() {
-        final String message = super.getMessage();
-        if (exception == null) {
-            return message;
-        }
-        final StringBuilder buf = new StringBuilder();
-        if (message != null) {
-            buf.append(message).append("; ");
-        }
-        final String eMsg = exception.getMessage();
-        buf.append(eMsg == null ? exception.getClass().getName() : eMsg);
-        return buf.toString();
-    }
 }