Fix PMD AvoidDecimalLiteralsInBigDecimalConstructor in

org.apache.commons.jxpath.util.BasicTypeConverter.allocateNumber(Class,
double)

Author: garydgregory

src/changes/changes.xml

@@ -134,6 +134,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action dev="ggregory" type="fix" due-to="Gary Gregory">Make the private JDOMNodePointer.id field final.</action>
       <action dev="ggregory" type="fix" due-to="Gary Gregory">ExpressionContext.getContextNodeList() now uses generics.</action>
       <action dev="ggregory" type="fix" due-to="Gary Gregory">BasicTypeConverter.unmodifiableCollection(Collection) now uses generics.</action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory. PMD">Fix PMD AvoidDecimalLiteralsInBigDecimalConstructor in org.apache.commons.jxpath.util.BasicTypeConverter.allocateNumber(Class, double).</action>
       <!-- ADD -->
       <action issue="JXPATH-123" dev="mbenson" type="add">
         XPath function "ends-with" is not implemented (although "starts-with" is).

src/main/java/org/apache/commons/jxpath/util/BasicTypeConverter.java

@@ -173,8 +173,7 @@ protected Number allocateNumber(Class type, final double value) {
             return BigInteger.valueOf((long) value);
         }
         if (type == BigDecimal.class) {
-            // TODO ? https://pmd.sourceforge.io/pmd-6.50.0/pmd_rules_java_errorprone.html#avoiddecimalliteralsinbigdecimalconstructor
-            return new BigDecimal(value); // NOPMD
+            return new BigDecimal(Double.toString(value));
         }
         final String className = type.getName();
         Class initialValueType = null;