Test builder and deprecated constructor

Author: garydgregory

src/test/java/org/apache/commons/lang3/builder/ReflectionDiffBuilderTest.java

@@ -63,6 +63,26 @@ private static class TypeTestClass implements Diffable<TypeTestClass> {
 
         @Override
         public DiffResult<TypeTestClass> diff(final TypeTestClass obj) {
+            // @formatter:off
+            return ReflectionDiffBuilder.<TypeTestClass>builder()
+                    .setDiffBuilder(diffBuilder(obj))
+                    .setExcludeFieldNames("excludedField")
+                    .build()
+                    .build();
+            // @formatter:on
+        }
+
+        DiffBuilder<TypeTestClass> diffBuilder(final TypeTestClass obj) {
+            // @formatter:off
+            return DiffBuilder.<TypeTestClass>builder()
+                .setLeft(this)
+                .setRight(obj)
+                .setStyle(style)
+                .build();
+            // @formatter:on
+        }
+
+        public DiffResult<TypeTestClass> diffDeprecated(final TypeTestClass obj) {
             return new ReflectionDiffBuilder<>(this, obj, style).setExcludeFieldNames("excludedField").build();
         }
 
@@ -84,8 +104,11 @@ public void testArrayDifference() {
         final TypeTestClass firstObject = new TypeTestClass();
         firstObject.charArrayField = new char[] { 'c' };
         final TypeTestClass secondObject = new TypeTestClass();
-
-        final DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        // Normal builder
+        DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        assertEquals(1, list.getNumberOfDiffs());
+        // Deprecated constructor
+        list = firstObject.diffDeprecated(secondObject);
         assertEquals(1, list.getNumberOfDiffs());
     }
 
@@ -182,19 +205,17 @@ public void testGetExcludeFieldNamesWithNullValuesInExcludedFieldNamesCtor() {
     public void testNoDifferences() {
         final TypeTestClass firstObject = new TypeTestClass();
         final TypeTestClass secondObject = new TypeTestClass();
-
-        final DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
-        assertEquals(0, list.getNumberOfDiffs());
+        assertEquals(0, firstObject.diff(secondObject).getNumberOfDiffs());
+        assertEquals(0, firstObject.diffDeprecated(secondObject).getNumberOfDiffs());
     }
 
     @Test
     public void testNoDifferencesDiffExcludeAnnotatedField() {
         final TypeTestClass firstObject = new TypeTestClass();
         firstObject.annotatedField = "b";
         final TypeTestClass secondObject = new TypeTestClass();
-
-        final DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
-        assertEquals(0, list.getNumberOfDiffs());
+        assertEquals(0, firstObject.diff(secondObject).getNumberOfDiffs());
+        assertEquals(0, firstObject.diffDeprecated(secondObject).getNumberOfDiffs());
     }
 
     @Test
@@ -203,8 +224,9 @@ public void testNoDifferencesDiffExcludedFieldAndExcludeAnnotatedField() {
         firstObject.excludedField = "b";
         firstObject.annotatedField = "b";
         final TypeTestClass secondObject = new TypeTestClass();
-
-        final DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        assertEquals(0, list.getNumberOfDiffs());
+        list = firstObject.diffDeprecated(secondObject);
         assertEquals(0, list.getNumberOfDiffs());
     }
 
@@ -213,17 +235,19 @@ public void testNoDifferencesExcludedField() {
         final TypeTestClass firstObject = new TypeTestClass();
         firstObject.excludedField = "b";
         final TypeTestClass secondObject = new TypeTestClass();
-
-        final DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        assertEquals(0, list.getNumberOfDiffs());
+        list = firstObject.diffDeprecated(secondObject);
         assertEquals(0, list.getNumberOfDiffs());
     }
 
     @Test
     public void testNoDifferencesInheritance() {
         final TypeTestChildClass firstObject = new TypeTestChildClass();
         final TypeTestChildClass secondObject = new TypeTestChildClass();
-
-        final DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        assertEquals(0, list.getNumberOfDiffs());
+        list = firstObject.diffDeprecated(secondObject);
         assertEquals(0, list.getNumberOfDiffs());
     }
 
@@ -232,8 +256,9 @@ public void testPrimitiveDifference() {
         final TypeTestClass firstObject = new TypeTestClass();
         firstObject.charField = 'c';
         final TypeTestClass secondObject = new TypeTestClass();
-
-        final DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        assertEquals(1, list.getNumberOfDiffs());
+        list = firstObject.diffDeprecated(secondObject);
         assertEquals(1, list.getNumberOfDiffs());
     }
 
@@ -243,8 +268,9 @@ public void testTransientFieldDifference() {
         firstObject.transientField = "a";
         final TypeTestClass secondObject = new TypeTestClass();
         firstObject.transientField = "b";
-
-        final DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        DiffResult<TypeTestClass> list = firstObject.diff(secondObject);
+        assertEquals(0, list.getNumberOfDiffs());
+        list = firstObject.diffDeprecated(secondObject);
         assertEquals(0, list.getNumberOfDiffs());
     }