Skip to content

Commit 13aebc3

Browse files
committed
Add assertions to
org.apache.commons.lang3.ClassUtilsTest.test_getShortCanonicalName_String()
1 parent 177911e commit 13aebc3

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/test/java/org/apache/commons/lang3/ClassUtilsTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -584,6 +584,15 @@ public void test_getShortCanonicalName_String() {
584584
assertEquals("String[]", ClassUtils.getShortCanonicalName(String[].class.getName()));
585585
assertEquals("String[]", ClassUtils.getShortCanonicalName(String[].class.getCanonicalName()));
586586
assertEquals("String[]", ClassUtils.getShortCanonicalName("String[]"));
587+
// Note that we throw RuntimeException (but not which one) for the following bad inputs:
588+
assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName(""));
589+
assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("["));
590+
assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[]"));
591+
assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[;"));
592+
assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[];"));
593+
assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName(" "));
594+
assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[$"));
595+
assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[$a"));
587596
}
588597

589598
@Test

0 commit comments

Comments
 (0)