Use JUnit 5 convention for test method visibility

Author: garydgregory

src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java

@@ -405,24 +405,24 @@ public void setup() throws Exception {
     }
 
     @Test
-    public void testAnnotationsOfDifferingTypes() {
+    void testAnnotationsOfDifferingTypes() {
         assertFalse(AnnotationUtils.equals(field1.getAnnotation(TestAnnotation.class), field4.getAnnotation(NestAnnotation.class)));
         assertFalse(AnnotationUtils.equals(field4.getAnnotation(NestAnnotation.class), field1.getAnnotation(TestAnnotation.class)));
     }
 
     @Test
-    public void testBothArgsNull() {
+    void testBothArgsNull() {
         assertTrue(AnnotationUtils.equals(null, null));
     }
 
     @Test
-    public void testEquivalence() {
+    void testEquivalence() {
         assertTrue(AnnotationUtils.equals(field1.getAnnotation(TestAnnotation.class), field2.getAnnotation(TestAnnotation.class)));
         assertTrue(AnnotationUtils.equals(field2.getAnnotation(TestAnnotation.class), field1.getAnnotation(TestAnnotation.class)));
     }
 
     @Test
-    public void testGeneratedAnnotationEquivalentToRealAnnotation() {
+    void testGeneratedAnnotationEquivalentToRealAnnotation() {
         assertTimeoutPreemptively(Duration.ofSeconds(666L), () -> {
             final Test real = getClass().getDeclaredMethod(
                     "testGeneratedAnnotationEquivalentToRealAnnotation").getAnnotation(Test.class);
@@ -459,7 +459,7 @@ public void testGeneratedAnnotationEquivalentToRealAnnotation() {
     }
 
     @Test
-    public void testHashCode() {
+    void testHashCode() {
         assertTimeoutPreemptively(Duration.ofSeconds(666L), () -> {
             final Test test = getClass().getDeclaredMethod("testHashCode").getAnnotation(Test.class);
             assertEquals(test.hashCode(), AnnotationUtils.hashCode(test));
@@ -471,7 +471,7 @@ public void testHashCode() {
     }
 
     @Test
-    public void testIsValidAnnotationMemberType() {
+    void testIsValidAnnotationMemberType() {
         for (final Class<?> type : new Class[] { byte.class, short.class, int.class, char.class,
                 long.class, float.class, double.class, boolean.class, String.class, Class.class,
                 NestAnnotation.class, TestAnnotation.class, Stooge.class, ElementType.class }) {
@@ -487,25 +487,25 @@ public void testIsValidAnnotationMemberType() {
     }
 
     @Test
-    public void testNonEquivalentAnnotationsOfSameType() {
+    void testNonEquivalentAnnotationsOfSameType() {
         assertFalse(AnnotationUtils.equals(field1.getAnnotation(TestAnnotation.class), field3.getAnnotation(TestAnnotation.class)));
         assertFalse(AnnotationUtils.equals(field3.getAnnotation(TestAnnotation.class), field1.getAnnotation(TestAnnotation.class)));
     }
 
     @Test
-    public void testOneArgNull() {
+    void testOneArgNull() {
         assertFalse(AnnotationUtils.equals(field1.getAnnotation(TestAnnotation.class), null));
         assertFalse(AnnotationUtils.equals(null, field1.getAnnotation(TestAnnotation.class)));
     }
 
     @Test
-    public void testSameInstance() {
+    void testSameInstance() {
         assertTrue(AnnotationUtils.equals(field1.getAnnotation(TestAnnotation.class), field1.getAnnotation(TestAnnotation.class)));
     }
 
     @Test
     @TestMethodAnnotation(timeout = 666000)
-    public void testToString() {
+    void testToString() {
         assertTimeoutPreemptively(Duration.ofSeconds(666L), () -> {
             final TestMethodAnnotation testAnnotation =
                     getClass().getDeclaredMethod("testToString").getAnnotation(TestMethodAnnotation.class);

src/test/java/org/apache/commons/lang3/AppendableJoinerTest.java

@@ -55,7 +55,7 @@ void render(final Appendable appendable) throws IOException {
     }
 
     @Test
-    public void testAllBuilderPropertiesStringBuilder() {
+    void testAllBuilderPropertiesStringBuilder() {
         // @formatter:off
         final AppendableJoiner<Object> joiner = AppendableJoiner.builder()
                 .setPrefix("<")
@@ -71,7 +71,7 @@ public void testAllBuilderPropertiesStringBuilder() {
     }
 
     @Test
-    public void testBuildDefaultStringBuilder() {
+    void testBuildDefaultStringBuilder() {
         final Builder<Object> builder = AppendableJoiner.builder();
         assertNotSame(builder.get(), builder.get());
         final AppendableJoiner<Object> joiner = builder.get();
@@ -82,14 +82,14 @@ public void testBuildDefaultStringBuilder() {
     }
 
     @Test
-    public void testBuilder() {
+    void testBuilder() {
         assertNotSame(AppendableJoiner.builder(), AppendableJoiner.builder());
     }
 
     @SuppressWarnings("deprecation") // Test own StrBuilder
     @ParameterizedTest
     @ValueSource(classes = { StringBuilder.class, StringBuffer.class, StringWriter.class, StrBuilder.class, TextStringBuilder.class })
-    public void testDelimiterAppendable(final Class<? extends Appendable> clazz) throws Exception {
+    void testDelimiterAppendable(final Class<? extends Appendable> clazz) throws Exception {
         final AppendableJoiner<Object> joiner = AppendableJoiner.builder().setDelimiter(".").get();
         final Appendable sbuilder = clazz.newInstance();
         sbuilder.append("A");
@@ -101,7 +101,7 @@ public void testDelimiterAppendable(final Class<? extends Appendable> clazz) thr
     }
 
     @Test
-    public void testDelimiterStringBuilder() {
+    void testDelimiterStringBuilder() {
         final AppendableJoiner<Object> joiner = AppendableJoiner.builder().setDelimiter(".").get();
         final StringBuilder sbuilder = new StringBuilder("A");
         // does not throw IOException
@@ -112,7 +112,7 @@ public void testDelimiterStringBuilder() {
     }
 
     @Test
-    public void testToCharSequenceStringBuilder1() {
+    void testToCharSequenceStringBuilder1() {
         // @formatter:off
         final AppendableJoiner<Object> joiner = AppendableJoiner.builder()
                 .setPrefix("<")
@@ -128,7 +128,7 @@ public void testToCharSequenceStringBuilder1() {
     }
 
     @Test
-    public void testToCharSequenceStringBuilder2() {
+    void testToCharSequenceStringBuilder2() {
         // @formatter:off
         final AppendableJoiner<Fixture> joiner = AppendableJoiner.<Fixture>builder()
                 .setElementAppender((a, e) -> e.render(a))

src/test/java/org/apache/commons/lang3/ArchUtilsTest.java

@@ -68,7 +68,7 @@ private void assertNotEqualsTypeNotNull(final Processor.Type type, final Process
     }
 
     @Test
-    public void testArch() {
+    void testArch() {
         Processor processor = ArchUtils.getProcessor(X86);
         assertEqualsTypeNotNull(Processor.Type.X86, processor);
         assertTrue(processor.isX86());
@@ -113,15 +113,15 @@ public void testArch() {
     }
 
     @Test
-    public void testArchLabels() {
+    void testArchLabels() {
         for (final Arch arch : Arch.values()) {
             // Only test label presence.
             assertFalse(arch.getLabel().isEmpty());
         }
     }
 
     @Test
-    public void testGetProcessor() {
+    void testGetProcessor() {
         assertNotNull(ArchUtils.getProcessor(X86));
         assertNull(ArchUtils.getProcessor("NA"));
         assertNull(ArchUtils.getProcessor(null));
@@ -131,7 +131,7 @@ public void testGetProcessor() {
     }
 
     @Test
-    public void testIs32BitJVM() {
+    void testIs32BitJVM() {
         Processor processor = ArchUtils.getProcessor(X86);
         assertEqualsArchNotNull(Processor.Arch.BIT_32, processor);
         assertTrue(processor.is32Bit());
@@ -166,7 +166,7 @@ public void testIs32BitJVM() {
     }
 
     @Test
-    public void testIs64BitJVM() {
+    void testIs64BitJVM() {
         Processor processor = ArchUtils.getProcessor(X86_64);
         assertEqualsArchNotNull(Processor.Arch.BIT_64, processor);
         assertTrue(processor.is64Bit());
@@ -207,7 +207,7 @@ public void testIs64BitJVM() {
 }
 
     @Test
-    public void testTypeLabels() {
+    void testTypeLabels() {
         for (final Type type : Type.values()) {
             // Only test label presence.
             assertFalse(type.getLabel().isEmpty());

src/test/java/org/apache/commons/lang3/ArrayFillTest.java

@@ -31,7 +31,7 @@
 public class ArrayFillTest extends AbstractLangTest {
 
     @Test
-    public void testFillBooleanArray() {
+    void testFillBooleanArray() {
         final boolean[] array = new boolean[3];
         final boolean val = true;
         final boolean[] actual = ArrayFill.fill(array, val);
@@ -42,15 +42,15 @@ public void testFillBooleanArray() {
     }
 
     @Test
-    public void testFillBooleanArrayNull() {
+    void testFillBooleanArrayNull() {
         final boolean[] array = null;
         final boolean val = true;
         final boolean[] actual = ArrayFill.fill(array, val);
         assertSame(array, actual);
     }
 
     @Test
-    public void testFillByteArray() {
+    void testFillByteArray() {
         final byte[] array = new byte[3];
         final byte val = (byte) 1;
         final byte[] actual = ArrayFill.fill(array, val);
@@ -61,15 +61,15 @@ public void testFillByteArray() {
     }
 
     @Test
-    public void testFillByteArrayNull() {
+    void testFillByteArrayNull() {
         final byte[] array = null;
         final byte val = (byte) 1;
         final byte[] actual = ArrayFill.fill(array, val);
         assertSame(array, actual);
     }
 
     @Test
-    public void testFillCharArray() {
+    void testFillCharArray() {
         final char[] array = new char[3];
         final char val = 1;
         final char[] actual = ArrayFill.fill(array, val);
@@ -80,15 +80,15 @@ public void testFillCharArray() {
     }
 
     @Test
-    public void testFillCharArrayNull() {
+    void testFillCharArrayNull() {
         final char[] array = null;
         final char val = 1;
         final char[] actual = ArrayFill.fill(array, val);
         assertSame(array, actual);
     }
 
     @Test
-    public void testFillDoubleArray() {
+    void testFillDoubleArray() {
         final double[] array = new double[3];
         final double val = 1;
         final double[] actual = ArrayFill.fill(array, val);
@@ -99,15 +99,15 @@ public void testFillDoubleArray() {
     }
 
     @Test
-    public void testFillDoubleArrayNull() {
+    void testFillDoubleArrayNull() {
         final double[] array = null;
         final double val = 1;
         final double[] actual = ArrayFill.fill(array, val);
         assertSame(array, actual);
     }
 
     @Test
-    public void testFillFloatArray() {
+    void testFillFloatArray() {
         final float[] array = new float[3];
         final float val = 1;
         final float[] actual = ArrayFill.fill(array, val);
@@ -118,15 +118,15 @@ public void testFillFloatArray() {
     }
 
     @Test
-    public void testFillFloatArrayNull() {
+    void testFillFloatArrayNull() {
         final float[] array = null;
         final float val = 1;
         final float[] actual = ArrayFill.fill(array, val);
         assertSame(array, actual);
     }
 
     @Test
-    public void testFillFunction() throws Exception {
+    void testFillFunction() throws Exception {
         final FailableIntFunction<?, Exception> nullIntFunction = null;
         assertNull(ArrayFill.fill(null, nullIntFunction));
         assertArrayEquals(null, ArrayFill.fill(null, nullIntFunction));
@@ -141,7 +141,7 @@ public void testFillFunction() throws Exception {
     }
 
     @Test
-    public void testFillIntArray() {
+    void testFillIntArray() {
         final int[] array = new int[3];
         final int val = 1;
         final int[] actual = ArrayFill.fill(array, val);
@@ -152,15 +152,15 @@ public void testFillIntArray() {
     }
 
     @Test
-    public void testFillIntArrayNull() {
+    void testFillIntArrayNull() {
         final int[] array = null;
         final int val = 1;
         final int[] actual = ArrayFill.fill(array, val);
         assertSame(array, actual);
     }
 
     @Test
-    public void testFillLongArray() {
+    void testFillLongArray() {
         final long[] array = new long[3];
         final long val = 1;
         final long[] actual = ArrayFill.fill(array, val);
@@ -171,15 +171,15 @@ public void testFillLongArray() {
     }
 
     @Test
-    public void testFillLongArrayNull() {
+    void testFillLongArrayNull() {
         final long[] array = null;
         final long val = 1;
         final long[] actual = ArrayFill.fill(array, val);
         assertSame(array, actual);
     }
 
     @Test
-    public void testFillObjectArray() {
+    void testFillObjectArray() {
         final String[] array = new String[3];
         final String val = "A";
         final String[] actual = ArrayFill.fill(array, val);
@@ -190,15 +190,15 @@ public void testFillObjectArray() {
     }
 
     @Test
-    public void testFillObjectArrayNull() {
+    void testFillObjectArrayNull() {
         final Object[] array = null;
         final Object val = 1;
         final Object[] actual = ArrayFill.fill(array, val);
         assertSame(array, actual);
     }
 
     @Test
-    public void testFillShortArray() {
+    void testFillShortArray() {
         final short[] array = new short[3];
         final short val = (byte) 1;
         final short[] actual = ArrayFill.fill(array, val);
@@ -209,7 +209,7 @@ public void testFillShortArray() {
     }
 
     @Test
-    public void testFillShortArrayNull() {
+    void testFillShortArrayNull() {
         final short[] array = null;
         final short val = 1;
         final short[] actual = ArrayFill.fill(array, val);