Add org.apache.commons.lang3.SystemUtils.IS_OS_NETWARE

I still see Java code that special case Netware...

Author: garydgregory

src/changes/changes.xml

@@ -59,7 +59,8 @@ The <action> type attribute can be add,update,fix,remove.
     <action                   type="fix" dev="ggregory" due-to="Hassan A Hashim">[javadoc] Fix Javadocs in ClassUtils #1410.</action>
     <action                   type="fix" dev="ggregory" due-to="mfg92">[javadoc] Fix @deprecated link for StringUtils#startsWithAny #1424.</action>
     <!-- ADD -->
-    <action                   type="fix" dev="ggregory" due-to="Gary Gregory">Add org.apache.commons.lang3.ArrayUtils.SOFT_MAX_ARRAY_LENGTH.</action>
+    <action                   type="add" dev="ggregory" due-to="Gary Gregory">Add org.apache.commons.lang3.ArrayUtils.SOFT_MAX_ARRAY_LENGTH.</action>
+    <action                   type="add" dev="ggregory" due-to="Gary Gregory">Add org.apache.commons.lang3.SystemUtils.IS_OS_NETWARE.</action>
     <!-- UPDATE -->
     <action type="update" dev="ggregory" due-to="Gary Gregory">[test] Bump org.apache.commons:commons-text from 1.13.1 to 1.14.0.</action>
   </release>

src/main/java/org/apache/commons/lang3/SystemUtils.java

@@ -1640,6 +1640,22 @@ public class SystemUtils {
      */
     public static final boolean IS_OS_NET_BSD = getOsNameMatches("NetBSD");
 
+    /**
+     * The constant {@code true} if this is Netware.
+     * <p>
+     * The result depends on the value of the {@link #OS_NAME} constant.
+     * </p>
+     * <p>
+     * The field will return {@code false} if {@link #OS_NAME} is {@code null}.
+     * </p>
+     * <p>
+     * This value is initialized when the class is loaded.
+     * </p>
+     *
+     * @since 3.19.0
+     */
+    public static final boolean IS_OS_NETWARE = getOsNameMatches("Netware");
+
     /**
      * The constant {@code true} if this is OS/2.
      * <p>

src/test/java/org/apache/commons/lang3/SystemUtilsTest.java

@@ -153,24 +153,29 @@ void test_IS_OS() {
             assertFalse(SystemUtils.IS_OS_SOLARIS);
             assertFalse(SystemUtils.IS_OS_LINUX);
             assertFalse(SystemUtils.IS_OS_MAC_OSX);
+            assertFalse(SystemUtils.IS_OS_NETWARE);
         } else if (osName.startsWith("Windows")) {
             assertTrue(SystemUtils.IS_OS_WINDOWS);
             assertFalse(SystemUtils.IS_OS_ANDROID);
             assertFalse(SystemUtils.IS_OS_UNIX);
+            assertFalse(SystemUtils.IS_OS_NETWARE);
         } else if (osName.startsWith("Solaris")) {
             assertTrue(SystemUtils.IS_OS_SOLARIS);
             assertTrue(SystemUtils.IS_OS_UNIX);
             assertFalse(SystemUtils.IS_OS_ANDROID);
             assertFalse(SystemUtils.IS_OS_WINDOWS);
+            assertFalse(SystemUtils.IS_OS_NETWARE);
         } else if (osName.toLowerCase(Locale.ENGLISH).startsWith("linux")) {
             assertTrue(SystemUtils.IS_OS_LINUX);
             assertTrue(SystemUtils.IS_OS_UNIX);
             assertFalse(SystemUtils.IS_OS_WINDOWS);
+            assertFalse(SystemUtils.IS_OS_NETWARE);
         } else if (osName.startsWith("Mac OS X")) {
             assertTrue(SystemUtils.IS_OS_MAC_OSX);
             assertTrue(SystemUtils.IS_OS_UNIX);
             assertFalse(SystemUtils.IS_OS_ANDROID);
             assertFalse(SystemUtils.IS_OS_WINDOWS);
+            assertFalse(SystemUtils.IS_OS_NETWARE);
             // @formatter:off
             final boolean[] macOsValues = {
                     SystemUtils.IS_OS_MAC_OSX_BIG_SUR,
@@ -204,16 +209,19 @@ void test_IS_OS() {
             assertFalse(SystemUtils.IS_OS_UNIX);
             assertFalse(SystemUtils.IS_OS_ANDROID);
             assertFalse(SystemUtils.IS_OS_WINDOWS);
+            assertFalse(SystemUtils.IS_OS_NETWARE);
         } else if (osName.startsWith("SunOS")) {
             assertTrue(SystemUtils.IS_OS_SUN_OS);
             assertTrue(SystemUtils.IS_OS_UNIX);
             assertFalse(SystemUtils.IS_OS_ANDROID);
             assertFalse(SystemUtils.IS_OS_WINDOWS);
+            assertFalse(SystemUtils.IS_OS_NETWARE);
         } else if (osName.startsWith("FreeBSD")) {
             assertTrue(SystemUtils.IS_OS_FREE_BSD);
             assertTrue(SystemUtils.IS_OS_UNIX);
             assertFalse(SystemUtils.IS_OS_ANDROID);
             assertFalse(SystemUtils.IS_OS_WINDOWS);
+            assertFalse(SystemUtils.IS_OS_NETWARE);
         } else {
             System.err.println("Can't test IS_OS_ value: " + osName);
         }