Skip to content

Commit 50a4eea

Browse files
garydgregorygarydgregory
committed
Refactor copy pasta
1 parent c74cbf9 commit 50a4eea

File tree

1 file changed

+38
-125
lines changed

1 file changed

+38
-125
lines changed

‎src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java‎

Lines changed: 38 additions & 125 deletions
Original file line numberDiff line numberDiff line change
@@ -150,162 +150,62 @@ private static final class JsonToStringStyle extends ToStringStyle {
150150
}
151151

152152
@Override
153-
public void append(final StringBuffer buffer, final String fieldName,
154-
final boolean[] array, final Boolean fullDetail) {
155-
156-
if (fieldName == null) {
157-
throw new UnsupportedOperationException(
158-
"Field names are mandatory when using JsonToStringStyle");
159-
}
160-
if (!isFullDetail(fullDetail)) {
161-
throw new UnsupportedOperationException(
162-
"FullDetail must be true when using JsonToStringStyle");
163-
}
164-
153+
public void append(final StringBuffer buffer, final String fieldName, final boolean[] array, final Boolean fullDetail) {
154+
checkAppendInput(fieldName, fullDetail);
165155
super.append(buffer, fieldName, array, fullDetail);
166156
}
167157

168158
@Override
169-
public void append(final StringBuffer buffer, final String fieldName, final byte[] array,
170-
final Boolean fullDetail) {
171-
172-
if (fieldName == null) {
173-
throw new UnsupportedOperationException(
174-
"Field names are mandatory when using JsonToStringStyle");
175-
}
176-
if (!isFullDetail(fullDetail)) {
177-
throw new UnsupportedOperationException(
178-
"FullDetail must be true when using JsonToStringStyle");
179-
}
180-
159+
public void append(final StringBuffer buffer, final String fieldName, final byte[] array, final Boolean fullDetail) {
160+
checkAppendInput(fieldName, fullDetail);
181161
super.append(buffer, fieldName, array, fullDetail);
182162
}
183163

184164
@Override
185-
public void append(final StringBuffer buffer, final String fieldName, final char[] array,
186-
final Boolean fullDetail) {
187-
188-
if (fieldName == null) {
189-
throw new UnsupportedOperationException(
190-
"Field names are mandatory when using JsonToStringStyle");
191-
}
192-
if (!isFullDetail(fullDetail)) {
193-
throw new UnsupportedOperationException(
194-
"FullDetail must be true when using JsonToStringStyle");
195-
}
196-
165+
public void append(final StringBuffer buffer, final String fieldName, final char[] array, final Boolean fullDetail) {
166+
checkAppendInput(fieldName, fullDetail);
197167
super.append(buffer, fieldName, array, fullDetail);
198168
}
199169

200170
@Override
201-
public void append(final StringBuffer buffer, final String fieldName,
202-
final double[] array, final Boolean fullDetail) {
203-
204-
if (fieldName == null) {
205-
throw new UnsupportedOperationException(
206-
"Field names are mandatory when using JsonToStringStyle");
207-
}
208-
if (!isFullDetail(fullDetail)) {
209-
throw new UnsupportedOperationException(
210-
"FullDetail must be true when using JsonToStringStyle");
211-
}
212-
171+
public void append(final StringBuffer buffer, final String fieldName, final double[] array, final Boolean fullDetail) {
172+
checkAppendInput(fieldName, fullDetail);
213173
super.append(buffer, fieldName, array, fullDetail);
214174
}
215175

216176
@Override
217-
public void append(final StringBuffer buffer, final String fieldName,
218-
final float[] array, final Boolean fullDetail) {
219-
220-
if (fieldName == null) {
221-
throw new UnsupportedOperationException(
222-
"Field names are mandatory when using JsonToStringStyle");
223-
}
224-
if (!isFullDetail(fullDetail)) {
225-
throw new UnsupportedOperationException(
226-
"FullDetail must be true when using JsonToStringStyle");
227-
}
228-
177+
public void append(final StringBuffer buffer, final String fieldName, final float[] array, final Boolean fullDetail) {
178+
checkAppendInput(fieldName, fullDetail);
229179
super.append(buffer, fieldName, array, fullDetail);
230180
}
231181

232182
@Override
233-
public void append(final StringBuffer buffer, final String fieldName, final int[] array,
234-
final Boolean fullDetail) {
235-
236-
if (fieldName == null) {
237-
throw new UnsupportedOperationException(
238-
"Field names are mandatory when using JsonToStringStyle");
239-
}
240-
if (!isFullDetail(fullDetail)) {
241-
throw new UnsupportedOperationException(
242-
"FullDetail must be true when using JsonToStringStyle");
243-
}
244-
183+
public void append(final StringBuffer buffer, final String fieldName, final int[] array, final Boolean fullDetail) {
184+
checkAppendInput(fieldName, fullDetail);
245185
super.append(buffer, fieldName, array, fullDetail);
246186
}
247187

248188
@Override
249-
public void append(final StringBuffer buffer, final String fieldName, final long[] array,
250-
final Boolean fullDetail) {
251-
252-
if (fieldName == null) {
253-
throw new UnsupportedOperationException(
254-
"Field names are mandatory when using JsonToStringStyle");
255-
}
256-
if (!isFullDetail(fullDetail)) {
257-
throw new UnsupportedOperationException(
258-
"FullDetail must be true when using JsonToStringStyle");
259-
}
260-
189+
public void append(final StringBuffer buffer, final String fieldName, final long[] array, final Boolean fullDetail) {
190+
checkAppendInput(fieldName, fullDetail);
261191
super.append(buffer, fieldName, array, fullDetail);
262192
}
263193

264194
@Override
265-
public void append(final StringBuffer buffer, final String fieldName, final Object value,
266-
final Boolean fullDetail) {
267-
268-
if (fieldName == null) {
269-
throw new UnsupportedOperationException(
270-
"Field names are mandatory when using JsonToStringStyle");
271-
}
272-
if (!isFullDetail(fullDetail)) {
273-
throw new UnsupportedOperationException(
274-
"FullDetail must be true when using JsonToStringStyle");
275-
}
276-
195+
public void append(final StringBuffer buffer, final String fieldName, final Object value, final Boolean fullDetail) {
196+
checkAppendInput(fieldName, fullDetail);
277197
super.append(buffer, fieldName, value, fullDetail);
278198
}
279199

280200
@Override
281-
public void append(final StringBuffer buffer, final String fieldName,
282-
final Object[] array, final Boolean fullDetail) {
283-
284-
if (fieldName == null) {
285-
throw new UnsupportedOperationException(
286-
"Field names are mandatory when using JsonToStringStyle");
287-
}
288-
if (!isFullDetail(fullDetail)) {
289-
throw new UnsupportedOperationException(
290-
"FullDetail must be true when using JsonToStringStyle");
291-
}
292-
201+
public void append(final StringBuffer buffer, final String fieldName, final Object[] array, final Boolean fullDetail) {
202+
checkAppendInput(fieldName, fullDetail);
293203
super.append(buffer, fieldName, array, fullDetail);
294204
}
295205

296206
@Override
297-
public void append(final StringBuffer buffer, final String fieldName,
298-
final short[] array, final Boolean fullDetail) {
299-
300-
if (fieldName == null) {
301-
throw new UnsupportedOperationException(
302-
"Field names are mandatory when using JsonToStringStyle");
303-
}
304-
if (!isFullDetail(fullDetail)) {
305-
throw new UnsupportedOperationException(
306-
"FullDetail must be true when using JsonToStringStyle");
307-
}
308-
207+
public void append(final StringBuffer buffer, final String fieldName, final short[] array, final Boolean fullDetail) {
208+
checkAppendInput(fieldName, fullDetail);
309209
super.append(buffer, fieldName, array, fullDetail);
310210
}
311211

@@ -325,7 +225,6 @@ protected void appendDetail(final StringBuffer buffer, final String fieldName, f
325225
buffer.append(getArrayEnd());
326226
return;
327227
}
328-
329228
buffer.append(coll);
330229
}
331230

@@ -390,10 +289,7 @@ protected void appendDetail(final StringBuffer buffer, final String fieldName, f
390289
@Override
391290
protected void appendFieldStart(final StringBuffer buffer, final String fieldName) {
392291

393-
if (fieldName == null) {
394-
throw new UnsupportedOperationException(
395-
"Field names are mandatory when using JsonToStringStyle");
396-
}
292+
checkFieldName(fieldName);
397293

398294
super.appendFieldStart(buffer, FIELD_NAME_QUOTE + StringEscapeUtils.escapeJson(fieldName)
399295
+ FIELD_NAME_QUOTE);
@@ -409,6 +305,23 @@ private void appendValueAsString(final StringBuffer buffer, final String value)
409305
buffer.append('"').append(StringEscapeUtils.escapeJson(value)).append('"');
410306
}
411307

308+
private void checkAppendInput(final String fieldName, final Boolean fullDetail) {
309+
checkFieldName(fieldName);
310+
checkIsFullDetail(fullDetail);
311+
}
312+
313+
private void checkFieldName(final String fieldName) {
314+
if (fieldName == null) {
315+
throw new UnsupportedOperationException("Field names are mandatory when using JsonToStringStyle");
316+
}
317+
}
318+
319+
private void checkIsFullDetail(final Boolean fullDetail) {
320+
if (!isFullDetail(fullDetail)) {
321+
throw new UnsupportedOperationException("FullDetail must be true when using JsonToStringStyle");
322+
}
323+
}
324+
412325
private boolean isJsonArray(final String valueAsString) {
413326
return valueAsString.startsWith(getArrayStart())
414327
&& valueAsString.endsWith(getArrayEnd());

0 commit comments

Comments
 (0)