Skip to content

Commit 61d0b32

Browse files
garydgregorygarydgregory
committed
Normalize test class names to *Test
1 parent 82c6f59 commit 61d0b32

9 files changed

+70
-3
lines changed

‎src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,15 @@
3434
import org.junit.jupiter.api.Test;
3535
import org.junit.jupiter.params.ParameterizedTest;
3636
import org.junit.jupiter.params.provider.MethodSource;
37+
import org.junitpioneer.jupiter.DefaultLocale;
38+
import org.junitpioneer.jupiter.DefaultTimeZone;
39+
import org.junitpioneer.jupiter.ReadsDefaultLocale;
40+
import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
3741

42+
/* Make test reproducible */ @DefaultLocale(language = "en")
43+
/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
44+
/* Make test reproducible */ @ReadsDefaultLocale
45+
/* Make test reproducible */ @ReadsDefaultTimeZone
3846
class CalendarUtilsTest extends AbstractLangTest {
3947

4048
@Test

‎src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,17 @@
3333
import org.junit.jupiter.api.Test;
3434
import org.junitpioneer.jupiter.DefaultLocale;
3535
import org.junitpioneer.jupiter.DefaultTimeZone;
36+
import org.junitpioneer.jupiter.ReadsDefaultLocale;
37+
import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
3638

3739
/**
3840
* TestCase for DateFormatUtils.
3941
*/
4042
@SuppressWarnings("deprecation") // tests lots of deprecated items
43+
/* Make test reproducible */ @DefaultLocale(language = "en")
44+
/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
45+
/* Make test reproducible */ @ReadsDefaultLocale
46+
/* Make test reproducible */ @ReadsDefaultTimeZone
4147
class DateFormatUtilsTest extends AbstractLangTest {
4248
private void assertFormats(final String expectedValue, final String pattern, final TimeZone timeZone, final Calendar cal) {
4349
assertEquals(expectedValue, DateFormatUtils.format(cal.getTime(), pattern, timeZone));

‎src/test/java/org/apache/commons/lang3/time/DateUtilsFragmentTest.java‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,15 @@
2525
import org.apache.commons.lang3.AbstractLangTest;
2626
import org.junit.jupiter.api.BeforeEach;
2727
import org.junit.jupiter.api.Test;
28-
28+
import org.junitpioneer.jupiter.DefaultLocale;
29+
import org.junitpioneer.jupiter.DefaultTimeZone;
30+
import org.junitpioneer.jupiter.ReadsDefaultLocale;
31+
import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
32+
33+
/* Make test reproducible */ @DefaultLocale(language = "en")
34+
/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
35+
/* Make test reproducible */ @ReadsDefaultLocale
36+
/* Make test reproducible */ @ReadsDefaultTimeZone
2937
class DateUtilsFragmentTest extends AbstractLangTest {
3038

3139
private static final int months = 7; // second final prime before 12

‎src/test/java/org/apache/commons/lang3/time/DateUtilsRoundingTest.java‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
import org.apache.commons.lang3.AbstractLangTest;
2929
import org.junit.jupiter.api.BeforeEach;
3030
import org.junit.jupiter.api.Test;
31+
import org.junitpioneer.jupiter.DefaultLocale;
32+
import org.junitpioneer.jupiter.DefaultTimeZone;
33+
import org.junitpioneer.jupiter.ReadsDefaultLocale;
34+
import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
3135

3236
/**
3337
* These Unit-tests will check all possible extremes when using some rounding-methods of DateUtils.
@@ -39,6 +43,10 @@
3943
* A month with 29 or 30 days will be rounded up from the 16th
4044
* A month with 31 days will be rounded up from the 17th
4145
*/
46+
/* Make test reproducible */ @DefaultLocale(language = "en")
47+
/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
48+
/* Make test reproducible */ @ReadsDefaultLocale
49+
/* Make test reproducible */ @ReadsDefaultTimeZone
4250
class DateUtilsRoundingTest extends AbstractLangTest {
4351

4452
DateFormat dateTimeParser;

‎src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,21 @@
3434
import org.apache.commons.lang3.AbstractLangTest;
3535
import org.apache.commons.lang3.time.DurationFormatUtils.Token;
3636
import org.junit.jupiter.api.Test;
37+
import org.junitpioneer.jupiter.DefaultLocale;
3738
import org.junitpioneer.jupiter.DefaultTimeZone;
39+
import org.junitpioneer.jupiter.ReadsDefaultLocale;
40+
import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
3841

3942
/**
4043
* Tests {@link DurationFormatUtils}.
4144
* <p>
4245
* NOT THREAD-SAFE.
4346
* </p>
4447
*/
48+
/* Make test reproducible */ @DefaultLocale(language = "en")
49+
/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
50+
/* Make test reproducible */ @ReadsDefaultLocale
51+
/* Make test reproducible */ @ReadsDefaultTimeZone
4552
class DurationFormatUtilsTest extends AbstractLangTest {
4653

4754
private static final int FOUR_YEARS = 365 * 3 + 366;

‎src/test/java/org/apache/commons/lang3/time/FastDateParser_MoreOrLessTest.java‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,15 @@
2828

2929
import org.apache.commons.lang3.AbstractLangTest;
3030
import org.junit.jupiter.api.Test;
31-
31+
import org.junitpioneer.jupiter.DefaultLocale;
32+
import org.junitpioneer.jupiter.DefaultTimeZone;
33+
import org.junitpioneer.jupiter.ReadsDefaultLocale;
34+
import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
35+
36+
/* Make test reproducible */ @DefaultLocale(language = "en")
37+
/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
38+
/* Make test reproducible */ @ReadsDefaultLocale
39+
/* Make test reproducible */ @ReadsDefaultTimeZone
3240
class FastDateParser_MoreOrLessTest extends AbstractLangTest {
3341

3442
private static final TimeZone NEW_YORK = TimeZone.getTimeZone("America/New_York");

‎src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,16 @@
3535
import org.junit.jupiter.api.Test;
3636
import org.junitpioneer.jupiter.DefaultLocale;
3737
import org.junitpioneer.jupiter.DefaultTimeZone;
38+
import org.junitpioneer.jupiter.ReadsDefaultLocale;
39+
import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
3840

3941
/**
4042
* Tests {@link org.apache.commons.lang3.time.FastDatePrinter}.
4143
*/
44+
/* Make test reproducible */ @DefaultLocale(language = "en")
45+
/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
46+
/* Make test reproducible */ @ReadsDefaultLocale
47+
/* Make test reproducible */ @ReadsDefaultTimeZone
4248
class FastDatePrinterTest extends AbstractLangTest {
4349

4450
private enum Expected1806 {

‎src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,15 @@
2626
import org.apache.commons.lang3.AbstractLangTest;
2727
import org.junit.jupiter.params.ParameterizedTest;
2828
import org.junit.jupiter.params.provider.MethodSource;
29-
29+
import org.junitpioneer.jupiter.DefaultLocale;
30+
import org.junitpioneer.jupiter.DefaultTimeZone;
31+
import org.junitpioneer.jupiter.ReadsDefaultLocale;
32+
import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
33+
34+
/* Make test reproducible */ @DefaultLocale(language = "en")
35+
/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
36+
/* Make test reproducible */ @ReadsDefaultLocale
37+
/* Make test reproducible */ @ReadsDefaultTimeZone
3038
class FastDatePrinterTimeZonesTest extends AbstractLangTest {
3139

3240
private static final String PATTERN = "h:mma z";

‎src/test/java/org/apache/commons/lang3/time/Java15BugFastDateParserTest.java‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@
2929
import org.junit.jupiter.api.Test;
3030
import org.junit.jupiter.params.ParameterizedTest;
3131
import org.junit.jupiter.params.provider.MethodSource;
32+
import org.junitpioneer.jupiter.DefaultLocale;
33+
import org.junitpioneer.jupiter.DefaultTimeZone;
34+
import org.junitpioneer.jupiter.ReadsDefaultLocale;
35+
import org.junitpioneer.jupiter.ReadsDefaultTimeZone;
3236

3337
/**
3438
* These tests fail on Java 15 due to a bug which was only fixed for Java 16.
@@ -37,6 +41,10 @@
3741
* <li>https://bugs.openjdk.java.net/browse/JDK-8248655</li>
3842
* </ul>
3943
*/
44+
/* Make test reproducible */ @DefaultLocale(language = "en")
45+
/* Make test reproducible */ @DefaultTimeZone(TimeZones.GMT_ID)
46+
/* Make test reproducible */ @ReadsDefaultLocale
47+
/* Make test reproducible */ @ReadsDefaultTimeZone
4048
class Java15BugFastDateParserTest extends AbstractLangTest {
4149

4250
/** @see org.apache.commons.lang3.time.FastDateParserTest#dateParserParameters() */

0 commit comments

Comments
 (0)