Skip to content

Commit 6513eb0

Browse files
authored
Fix internal inverted logic in private isEnum() method and correct its usage in getFirstEnum() (#1454)
* Optimize ObjectToStringComparator.compare() method * Fix inverted logic in isEnum() method and correct its usage in getFirstEnum()
1 parent 756436b commit 6513eb0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/org/apache/commons/lang3/EnumUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ public static <E extends Enum<E>> E getEnumSystemProperty(final Class<E> enumCla
343343
* @since 3.18.0
344344
*/
345345
public static <E extends Enum<E>> E getFirstEnum(final Class<E> enumClass, final int value, final ToIntFunction<E> toIntFunction, final E defaultEnum) {
346-
if (isEnum(enumClass)) {
346+
if (!isEnum(enumClass)) {
347347
return defaultEnum;
348348
}
349349
return stream(enumClass).filter(e -> value == toIntFunction.applyAsInt(e)).findFirst().orElse(defaultEnum);
@@ -372,7 +372,7 @@ public static <E extends Enum<E>> E getFirstEnumIgnoreCase(final Class<E> enumCl
372372
}
373373

374374
private static <E extends Enum<E>> boolean isEnum(final Class<E> enumClass) {
375-
return enumClass != null && !enumClass.isEnum();
375+
return enumClass != null && enumClass.isEnum();
376376
}
377377

378378
/**

0 commit comments

Comments
 (0)