Skip to content

Commit 9828dc7

Browse files
LANG-1695: Allow trailing decimal point in NumberUtils.isParsable (#1531)
* LANG-1695: Allow trailing decimal point in NumberUtils.isParsable * Remove extra blank line --------- Co-authored-by: Gary Gregory <[email protected]>
1 parent 0917cde commit 9828dc7

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/main/java/org/apache/commons/lang3/math/NumberUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -724,7 +724,7 @@ public static boolean isNumber(final String str) {
724724
* @since 3.4
725725
*/
726726
public static boolean isParsable(final String str) {
727-
if (StringUtils.isEmpty(str) || str.charAt(str.length() - 1) == '.') {
727+
if (StringUtils.isEmpty(str)) {
728728
return false;
729729
}
730730
if (str.charAt(0) == '-') {

src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1013,7 +1013,7 @@ void testIsParsable() {
10131013
assertFalse(NumberUtils.isParsable("pendro"));
10141014
assertFalse(NumberUtils.isParsable("64, 2"));
10151015
assertFalse(NumberUtils.isParsable("64.2.2"));
1016-
assertFalse(NumberUtils.isParsable("64."));
1016+
assertTrue(NumberUtils.isParsable("64."));
10171017
assertFalse(NumberUtils.isParsable("64L"));
10181018
assertFalse(NumberUtils.isParsable("-"));
10191019
assertFalse(NumberUtils.isParsable("--2"));
@@ -1025,6 +1025,7 @@ void testIsParsable() {
10251025
assertTrue(NumberUtils.isParsable("-018"));
10261026
assertTrue(NumberUtils.isParsable("-018.2"));
10271027
assertTrue(NumberUtils.isParsable("-.236"));
1028+
assertTrue(NumberUtils.isParsable("2."));
10281029
}
10291030

10301031
/**

0 commit comments

Comments
 (0)