Deprecate NumberUtils.compare(byte, byte) in favor of Byte.compare(byte,

byte)

Author: garydgregory

src/changes/changes.xml

@@ -61,6 +61,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action issue="LANG-1720" type="fix" dev="ggregory" due-to="Sheung Chi Chan, Arthur Chan, Gary Gregory, Elliotte Rusty Harold">Improve Javadocs for Conversion.</action>
     <action                   type="fix" dev="ggregory" due-to="mayuming">Fix CalendarUtils.toLocalDate() Javadoc return type description #1440.</action>
     <action                   type="fix" dev="ggregory" due-to="mayuming">Fix the method name in Javadoc examples for CharUtils.isHex() #1444.</action>
+    <action                   type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate NumberUtils.compare(byte, byte) in favor of Byte.compare(byte, byte).</action>
     <!-- FIX Javadoc -->
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">[javadoc] General improvements.</action>
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">[javadoc] Fix thrown exception documentation for org.apache.commons.lang3.reflect.MethodUtils.getMethodObject(Class&lt;?&gt;, String, Class&lt;?&gt;...).</action>

src/main/java/org/apache/commons/lang3/ArrayUtils.java

@@ -3622,7 +3622,7 @@ public static boolean isSorted(final byte[] array) {
         final int n = array.length;
         for (int i = 1; i < n; i++) {
             final byte current = array[i];
-            if (NumberUtils.compare(previous, current) > 0) {
+            if (Byte.compare(previous, current) > 0) {
                 return false;
             }
             previous = current;

src/main/java/org/apache/commons/lang3/math/NumberUtils.java

@@ -95,9 +95,11 @@ public class NumberUtils {
      *         a value less than {@code 0} if {@code x < y}; and
      *         a value greater than {@code 0} if {@code x > y}
      * @since 3.4
+     * @deprecated Use {@link Byte#compare(byte, byte)}.
      */
+    @Deprecated
     public static int compare(final byte x, final byte y) {
-        return x - y;
+        return Byte.compare(x, y);
     }
 
     /**

src/main/java/org/apache/commons/lang3/mutable/MutableByte.java

@@ -16,8 +16,6 @@
  */
 package org.apache.commons.lang3.mutable;
 
-import org.apache.commons.lang3.math.NumberUtils;
-
 /**
  * A mutable {@code byte} wrapper.
  * <p>
@@ -142,7 +140,7 @@ public byte byteValue() {
      */
     @Override
     public int compareTo(final MutableByte other) {
-        return NumberUtils.compare(this.value, other.value);
+        return Byte.compare(this.value, other.value);
     }
 
     /**