Normalize parameter names

Author: garydgregory

src/main/java/org/apache/commons/lang3/Streams.java

@@ -540,13 +540,13 @@ public static <O> FailableStream<O> stream(final Stream<O> stream) {
      * Returns a {@link Collector} that accumulates the input elements into a
      * new array.
      *
-     * @param pElementType Type of an element in the array.
+     * @param elementType Type of an element in the array.
      * @param <O> the type of the input elements
      * @return a {@link Collector} which collects all the input elements into an
      * array, in encounter order
      */
-    public static <O> Collector<O, ?, O[]> toArray(final Class<O> pElementType) {
-        return new ArrayCollector<>(pElementType);
+    public static <O> Collector<O, ?, O[]> toArray(final Class<O> elementType) {
+        return new ArrayCollector<>(elementType);
     }
 
     /**

src/test/java/org/apache/commons/lang3/FunctionsTest.java

@@ -68,9 +68,9 @@ public void reset() {
             closed = false;
         }
 
-        public void run(final Throwable pTh) throws Throwable {
-            if (pTh != null) {
-                throw pTh;
+        public void run(final Throwable throwable) throws Throwable {
+            if (throwable != null) {
+                throw throwable;
             }
         }
     }

src/test/java/org/apache/commons/lang3/StreamsTest.java

@@ -45,19 +45,19 @@
 @Deprecated
 public class StreamsTest extends AbstractLangTest {
 
-    protected <T extends Throwable> FailableConsumer<String, T> asIntConsumer(final T pThrowable) {
+    protected <T extends Throwable> FailableConsumer<String, T> asIntConsumer(final T throwable) {
         return s -> {
             final int i = Integer.parseInt(s);
             if (i == 4) {
-                throw pThrowable;
+                throw throwable;
             }
         };
     }
 
-    protected <T extends Throwable> FailablePredicate<Integer, T> asIntPredicate(final T pThrowable) {
+    protected <T extends Throwable> FailablePredicate<Integer, T> asIntPredicate(final T phrowable) {
         return i -> {
-            if (i.intValue() == 5 && pThrowable != null) {
-                throw pThrowable;
+            if (i.intValue() == 5 && phrowable != null) {
+                throw phrowable;
             }
             return i % 2 == 0;
         };

src/test/java/org/apache/commons/lang3/builder/DefaultToStringStyleTest.java

@@ -147,8 +147,8 @@ public void testPerson() {
         p.name = "John Doe";
         p.age = 33;
         p.smoker = false;
-        final String pBaseStr = p.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p));
-        assertEquals(pBaseStr + "[name=John Doe,age=33,smoker=false]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
+        final String baseStr = p.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p));
+        assertEquals(baseStr + "[name=John Doe,age=33,smoker=false]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
     }
 
 }

src/test/java/org/apache/commons/lang3/builder/MultiLineToStringStyleTest.java

@@ -147,8 +147,8 @@ public void testPerson() {
         p.name = "Jane Doe";
         p.age = 25;
         p.smoker = true;
-        final String pBaseStr = p.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p));
-        assertEquals(pBaseStr + "[" + System.lineSeparator() + "  name=Jane Doe" + System.lineSeparator() + "  age=25" + System.lineSeparator() + "  smoker=true" + System.lineSeparator() + "]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
+        final String baseStr = p.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p));
+        assertEquals(baseStr + "[" + System.lineSeparator() + "  name=Jane Doe" + System.lineSeparator() + "  age=25" + System.lineSeparator() + "  smoker=true" + System.lineSeparator() + "]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
     }
 
 }

src/test/java/org/apache/commons/lang3/builder/NoFieldNamesToStringStyleTest.java

@@ -147,8 +147,8 @@ public void testPerson() {
         p.name = "Ron Paul";
         p.age = 72;
         p.smoker = false;
-        final String pBaseStr = p.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p));
-        assertEquals(pBaseStr + "[Ron Paul,72,false]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
+        final String baseStr = p.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p));
+        assertEquals(baseStr + "[Ron Paul,72,false]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
     }
 
 }

src/test/java/org/apache/commons/lang3/builder/RecursiveToStringStyleTest.java

@@ -154,9 +154,9 @@ public void testPerson() {
         p.smoker = false;
         p.job = new Job();
         p.job.title = "Manager";
-        final String pBaseStr = p.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p));
-        final String pJobStr  = p.job.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p.job));
-        assertEquals(pBaseStr + "[age=33,job=" + pJobStr + "[title=Manager],name=John Doe,smoker=false]",
+        final String baseStr = p.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p));
+        final String jobStr  = p.job.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(p.job));
+        assertEquals(baseStr + "[age=33,job=" + jobStr + "[title=Manager],name=John Doe,smoker=false]",
                      new ReflectionToStringBuilder(p, new RecursiveToStringStyle()).toString());
     }
 

src/test/java/org/apache/commons/lang3/builder/ShortPrefixToStringStyleTest.java

@@ -147,8 +147,8 @@ public void testPerson() {
         p.name = "John Q. Public";
         p.age = 45;
         p.smoker = true;
-        final String pBaseStr = "ToStringStyleTest.Person";
-        assertEquals(pBaseStr + "[name=John Q. Public,age=45,smoker=true]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
+        final String baseStr = "ToStringStyleTest.Person";
+        assertEquals(baseStr + "[name=John Q. Public,age=45,smoker=true]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
     }
 
 }

src/test/java/org/apache/commons/lang3/builder/StandardToStringStyleTest.java

@@ -224,7 +224,7 @@ public void testPerson() {
         p.name = "Suzy Queue";
         p.age = 19;
         p.smoker = false;
-        final String pBaseStr = "ToStringStyleTest.Person";
-        assertEquals(pBaseStr + "[name=Suzy Queue,age=19,smoker=false]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
+        final String baseStr = "ToStringStyleTest.Person";
+        assertEquals(baseStr + "[name=Suzy Queue,age=19,smoker=false]", new ToStringBuilder(p).append("name", p.name).append("age", p.age).append("smoker", p.smoker).toString());
     }
 }

src/test/java/org/apache/commons/lang3/function/FailableFunctionsTest.java

@@ -62,9 +62,9 @@ public void reset() {
             closed = false;
         }
 
-        public void run(final Throwable pTh) throws Throwable {
-            if (pTh != null) {
-                throw pTh;
+        public void run(final Throwable throwable) throws Throwable {
+            if (throwable != null) {
+                throw throwable;
             }
         }
     }