Use JUnit Pioneer to avoid side effects

Author: garydgregory

src/test/java/org/apache/commons/lang3/StringUtilsContainsTest.java

@@ -28,6 +28,8 @@
 
 import org.junit.jupiter.api.Test;
 import org.junitpioneer.jupiter.DefaultLocale;
+import org.junitpioneer.jupiter.ReadsDefaultLocale;
+import org.junitpioneer.jupiter.WritesDefaultLocale;
 
 /**
  * Tests {@link StringUtils} - Contains methods
@@ -230,8 +232,10 @@ public void testContainsAnyIgnoreCase_StringStringArray() {
         assertTrue(StringUtils.containsAnyIgnoreCase("abc", "d", "abc"));
     }
 
-    @DefaultLocale(language = "de", country = "DE")
     @Test
+    @DefaultLocale(language = "de", country = "DE")
+    @ReadsDefaultLocale
+    @WritesDefaultLocale
     public void testContainsIgnoreCase_LocaleIndependence() {
         final Locale[] locales = { Locale.ENGLISH, new Locale("tr"), Locale.getDefault() };
 

src/test/java/org/apache/commons/lang3/StringUtilsTest.java

@@ -51,6 +51,8 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
+import org.junitpioneer.jupiter.ReadsDefaultLocale;
+import org.junitpioneer.jupiter.WritesDefaultLocale;
 
 /**
  * Tests for methods of {@link StringUtils}
@@ -3089,6 +3091,8 @@ public void testToEncodedString() {
     }
 
     @Test
+    @ReadsDefaultLocale
+    @WritesDefaultLocale
     public void testToRootLowerCase() {
         assertNull(StringUtils.toRootLowerCase(null));
         assertEquals("a", StringUtils.toRootLowerCase("A"));
@@ -3109,6 +3113,8 @@ public void testToRootLowerCase() {
     }
 
     @Test
+    @ReadsDefaultLocale
+    @WritesDefaultLocale
     public void testToRootUpperCase() {
         assertNull(StringUtils.toRootUpperCase(null));
         assertEquals("A", StringUtils.toRootUpperCase("a"));