Skip to content

Commit d45f23e

Browse files
committed
Refactor some exception tests
1 parent d575811 commit d45f23e

File tree

3 files changed

+113
-55
lines changed

3 files changed

+113
-55
lines changed
Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one or more
3+
* contributor license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright ownership.
5+
* The ASF licenses this file to You under the Apache License, Version 2.0
6+
* (the "License"); you may not use this file except in compliance with
7+
* the License. You may obtain a copy of the License at
8+
*
9+
* https://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
18+
package org.apache.commons.lang3.concurrent;
19+
20+
import static org.apache.commons.lang3.LangAssertions.assertIllegalArgumentException;
21+
import static org.junit.jupiter.api.Assertions.assertEquals;
22+
import static org.junit.jupiter.api.Assertions.assertNull;
23+
24+
import org.junit.jupiter.api.Test;
25+
26+
/**
27+
* Tests {@link ConcurrentException}.
28+
*/
29+
class ConcurrentExceptionTest {
30+
31+
/**
32+
* Tests creating a ConcurrentException with an error as cause.
33+
*/
34+
@Test
35+
void testCauseError() {
36+
assertIllegalArgumentException(() -> new ConcurrentException("An error", new Error()));
37+
}
38+
39+
/**
40+
* Tests creating a ConcurrentException with null as cause.
41+
*/
42+
@Test
43+
void testCauseNull() {
44+
assertIllegalArgumentException(() -> new ConcurrentException((Throwable) null));
45+
}
46+
47+
@Test
48+
void testCauseString() {
49+
assertEquals("test", new ConcurrentException("test").getMessage());
50+
assertNull(new ConcurrentException((String) null).getMessage());
51+
}
52+
53+
/**
54+
* Tests creating a ConcurrentException with a runtime exception as cause.
55+
*/
56+
@Test
57+
void testCauseUnchecked() {
58+
assertIllegalArgumentException(() -> new ConcurrentException(new RuntimeException()));
59+
}
60+
}
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one or more
3+
* contributor license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright ownership.
5+
* The ASF licenses this file to You under the Apache License, Version 2.0
6+
* (the "License"); you may not use this file except in compliance with
7+
* the License. You may obtain a copy of the License at
8+
*
9+
* https://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
18+
package org.apache.commons.lang3.concurrent;
19+
20+
import static org.apache.commons.lang3.LangAssertions.assertIllegalArgumentException;
21+
22+
import org.junit.jupiter.api.Test;
23+
24+
/**
25+
* Tests {@link ConcurrentRuntimeException}.
26+
*/
27+
class ConcurrentRuntimeExceptionTest {
28+
29+
/**
30+
* Tries to create a ConcurrentRuntimeException with an error as cause.
31+
*/
32+
@Test
33+
void testCauseError() {
34+
assertIllegalArgumentException(() -> new ConcurrentRuntimeException("An error", new Error()));
35+
}
36+
37+
/**
38+
* Tries to create a ConcurrentRuntimeException with null as cause.
39+
*/
40+
@Test
41+
void testCauseNull() {
42+
assertIllegalArgumentException(() -> new ConcurrentRuntimeException(null));
43+
}
44+
45+
/**
46+
* Tries to create a ConcurrentRuntimeException with a runtime as cause.
47+
*/
48+
@Test
49+
void testCauseUnchecked() {
50+
assertIllegalArgumentException(() -> new ConcurrentRuntimeException(new RuntimeException()));
51+
}
52+
}

src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java

Lines changed: 1 addition & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17+
1718
package org.apache.commons.lang3.concurrent;
1819

19-
import static org.apache.commons.lang3.LangAssertions.assertIllegalArgumentException;
2020
import static org.junit.jupiter.api.Assertions.assertEquals;
2121
import static org.junit.jupiter.api.Assertions.assertFalse;
2222
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -39,60 +39,6 @@
3939
* Test class for {@link ConcurrentUtils}.
4040
*/
4141
class ConcurrentUtilsTest extends AbstractLangTest {
42-
/**
43-
* Tests creating a ConcurrentException with an error as cause.
44-
*/
45-
@Test
46-
void testConcurrentExceptionCauseError() {
47-
assertIllegalArgumentException(() -> new ConcurrentException("An error", new Error()));
48-
}
49-
50-
/**
51-
* Tests creating a ConcurrentException with null as cause.
52-
*/
53-
@Test
54-
void testConcurrentExceptionCauseNull() {
55-
assertIllegalArgumentException(() -> new ConcurrentException((Throwable) null));
56-
}
57-
58-
@Test
59-
void testConcurrentExceptionCauseString() {
60-
assertEquals("test", new ConcurrentException("test").getMessage());
61-
assertNull(new ConcurrentException((String) null).getMessage());
62-
}
63-
64-
/**
65-
* Tests creating a ConcurrentException with a runtime exception as cause.
66-
*/
67-
@Test
68-
void testConcurrentExceptionCauseUnchecked() {
69-
assertIllegalArgumentException(() -> new ConcurrentException(new RuntimeException()));
70-
}
71-
72-
/**
73-
* Tries to create a ConcurrentRuntimeException with an error as cause.
74-
*/
75-
@Test
76-
void testConcurrentRuntimeExceptionCauseError() {
77-
assertIllegalArgumentException(() -> new ConcurrentRuntimeException("An error", new Error()));
78-
}
79-
80-
/**
81-
* Tries to create a ConcurrentRuntimeException with null as cause.
82-
*/
83-
@Test
84-
void testConcurrentRuntimeExceptionCauseNull() {
85-
assertIllegalArgumentException(() -> new ConcurrentRuntimeException(null));
86-
}
87-
88-
/**
89-
* Tries to create a ConcurrentRuntimeException with a runtime as cause.
90-
*/
91-
@Test
92-
void testConcurrentRuntimeExceptionCauseUnchecked() {
93-
assertIllegalArgumentException(() -> new ConcurrentRuntimeException(new RuntimeException()));
94-
}
95-
9642
/**
9743
* Tests constant future.
9844
*

0 commit comments

Comments
 (0)