Rename internal method

Author: garydgregory

src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java

@@ -214,7 +214,7 @@ static class IdentityWrapper<T> {
          * @param pooledObject contains the object to wrap.
          * @return a new instance wrapping the object in the {@link PooledObject}.
          */
-        static <T> IdentityWrapper<T> on(final PooledObject<T> pooledObject) {
+        static <T> IdentityWrapper<T> unwrap(final PooledObject<T> pooledObject) {
             return new IdentityWrapper<>(pooledObject.getObject());
         }
 

src/main/java/org/apache/commons/pool3/impl/GenericKeyedObjectPool.java

@@ -817,7 +817,7 @@ private PooledObject<T> create(final K key) throws E {
         }
 
         createdCount.incrementAndGet();
-        objectDeque.getAllObjects().put(IdentityWrapper.on(p), p);
+        objectDeque.getAllObjects().put(IdentityWrapper.unwrap(p), p);
         return p;
     }
 
@@ -880,7 +880,7 @@ private boolean destroy(final K key, final PooledObject<T> toDestroy, final bool
                 }
             }
             if (isIdle || always) {
-                objectDeque.getAllObjects().remove(IdentityWrapper.on(toDestroy));
+                objectDeque.getAllObjects().remove(IdentityWrapper.unwrap(toDestroy));
                 toDestroy.invalidate();
 
                 try {

src/main/java/org/apache/commons/pool3/impl/GenericObjectPool.java

@@ -606,7 +606,7 @@ private PooledObject<T> create(final Duration maxWaitDurationRequest) throws E {
     private void destroy(final PooledObject<T> toDestroy, final DestroyMode destroyMode) throws E {
         toDestroy.invalidate();
         idleObjects.remove(toDestroy);
-        allObjects.remove(IdentityWrapper.on(toDestroy));
+        allObjects.remove(IdentityWrapper.unwrap(toDestroy));
         try {
             factory.destroyObject(toDestroy, destroyMode);
         } finally {