Make some classes final

Author: garydgregory

src/changes/changes.xml

@@ -27,6 +27,7 @@
     <release version="1.9.2" date="YYYY-MM-DD" description="This is a feature and maintenance release. Java 8 or later is required.">
       <!-- FIX -->
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix Apache RAT plugin console warnings.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Make some classes final.</action>
       <!-- ADD -->
       <!-- UPDATE -->
       <action type="update" dev="ggregory" due-to="Gary Gregory">Bump org.apache.commons:commons-parent from 85 to 93 #396, #399, #419, #420.</action>

src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java

@@ -52,7 +52,7 @@
         defaultPhase = LifecyclePhase.VERIFY,
         threadSafe = true,
         aggregator = true)
-public class CommonsDistributionDetachmentMojo extends AbstractMojo {
+public final class CommonsDistributionDetachmentMojo extends AbstractMojo {
 
     /**
      * A list of "artifact types" in the Maven vernacular, to

src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java

@@ -69,7 +69,7 @@
         defaultPhase = LifecyclePhase.DEPLOY,
         threadSafe = true,
         aggregator = true)
-public class CommonsDistributionStagingMojo extends AbstractMojo {
+public final class CommonsDistributionStagingMojo extends AbstractMojo {
 
     /** The name of file generated from the README.vm velocity template to be checked into the dist svn repo. */
     private static final String README_FILE_NAME = "README.html";

src/main/java/org/apache/commons/release/plugin/mojos/CommonsSiteCompressionMojo.java

@@ -48,7 +48,7 @@
         defaultPhase = LifecyclePhase.POST_SITE,
         threadSafe = true,
         aggregator = true)
-public class CommonsSiteCompressionMojo extends AbstractMojo {
+public final class CommonsSiteCompressionMojo extends AbstractMojo {
 
     /**
      * The working directory for the plugin which, assuming the maven uses the default

src/main/java/org/apache/commons/release/plugin/mojos/CommonsStagingCleanupMojo.java

@@ -54,7 +54,7 @@
         defaultPhase = LifecyclePhase.POST_CLEAN,
         threadSafe = true,
         aggregator = true)
-public class CommonsStagingCleanupMojo extends AbstractMojo {
+public final class CommonsStagingCleanupMojo extends AbstractMojo {
 
     /**
      * The {@link MavenProject} object is essentially the context of the maven build at

src/main/java/org/apache/commons/release/plugin/velocity/HeaderHtmlVelocityDelegate.java

@@ -30,12 +30,12 @@
  *
  * @since 1.3
  */
-public class HeaderHtmlVelocityDelegate {
+public final class HeaderHtmlVelocityDelegate {
 
     /**
      * A builder class for instantiation of the {@link HeaderHtmlVelocityDelegate}.
      */
-    public static class HeaderHtmlVelocityDelegateBuilder {
+    public static final class HeaderHtmlVelocityDelegateBuilder {
 
         /**
          * Private constructor so that we can have a proper builder pattern.

src/main/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegate.java

@@ -31,11 +31,11 @@
  *
  * @since 1.3
  */
-public class ReadmeHtmlVelocityDelegate {
+public final class ReadmeHtmlVelocityDelegate {
     /**
      * A builder class for instantiation of the {@link ReadmeHtmlVelocityDelegate}.
      */
-    public static class ReadmeHtmlVelocityDelegateBuilder {
+    public static final class ReadmeHtmlVelocityDelegateBuilder {
         /** The maven artifactId to use in the <code>README.vm</code> template. */
         private String artifactId;
         /** The maven version to use in the <code>README.vm</code> template. */

src/test/java/org/apache/commons/release/plugin/stubs/DistributionDetachmentProjectStub.java

@@ -36,9 +36,9 @@
  *
  * @since 1.0
  */
-public class DistributionDetachmentProjectStub extends MavenProjectStub {
+public final class DistributionDetachmentProjectStub extends MavenProjectStub {
 
-    public static class DistributionDetachmentArtifactStub extends ArtifactStub {
+    public static final class DistributionDetachmentArtifactStub extends ArtifactStub {
 
         private final File artifact;
 

src/test/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegateTest.java

@@ -27,7 +27,7 @@
 /**
  * Unit tests for {@link ReadmeHtmlVelocityDelegate}.
  */
-public class ReadmeHtmlVelocityDelegateTest {
+public final class ReadmeHtmlVelocityDelegateTest {
 
     @Test
     public void testSuccessfulRun() throws IOException {