Sonar fix: use method reference

Author: aherbert

commons-rng-core/src/test/java/org/apache/commons/rng/core/ProvidersList.java

@@ -171,10 +171,10 @@ public final class ProvidersList {
             LIST.addAll(LIST64);
             // Dynamically identify the sub-type RNGs
             LIST.stream()
-                .filter(rng -> rng instanceof JumpableUniformRandomProvider)
+                .filter(JumpableUniformRandomProvider.class::isInstance)
                 .forEach(rng -> LIST_JUMP.add((JumpableUniformRandomProvider) rng));
             LIST.stream()
-                .filter(rng -> rng instanceof SplittableUniformRandomProvider)
+                .filter(SplittableUniformRandomProvider.class::isInstance)
                 .forEach(rng -> LIST_SPLIT.add((SplittableUniformRandomProvider) rng));
         } catch (final Exception e) {
             // CHECKSTYLE: stop Regexp

commons-rng-core/src/test/java/org/apache/commons/rng/core/source64/XoRoShiRo128PlusPlusTest.java

@@ -119,6 +119,6 @@ void testLongJump() {
     @Test
     void testNextOutputThrows() {
         final XoRoShiRo128PlusPlus rng = new XoRoShiRo128PlusPlus(SEED);
-        Assertions.assertThrows(UnsupportedOperationException.class, () -> rng.nextOutput());
+        Assertions.assertThrows(UnsupportedOperationException.class, rng::nextOutput);
     }
 }

commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java

@@ -35,8 +35,7 @@ void testInfiniteLoop() {
 
         // Infinite loop (in v1.1).
         final ZigguratNormalizedGaussianSampler sampler = new ZigguratNormalizedGaussianSampler(bad);
-        Assertions.assertThrows(StackOverflowError.class,
-            () -> sampler.sample());
+        Assertions.assertThrows(StackOverflowError.class, sampler::sample);
     }
 
     /**

commons-rng-simple/src/test/java/org/apache/commons/rng/simple/ProvidersCommonParametricTest.java

@@ -119,7 +119,7 @@ void testCreateMethodThrowsWithIncorrectArguments(ProvidersList.Data data) {
         } else {
             // Try no arguments for a provider that does require them
             Assertions.assertThrows(IllegalArgumentException.class,
-                () -> originalSource.create(),
+                originalSource::create,
                 () -> "Source requires arguments: " + originalSource);
         }
     }

commons-rng-simple/src/test/java/org/apache/commons/rng/simple/internal/RandomSourceInternalParametricTest.java

@@ -215,6 +215,6 @@ void testCreateSeedBytes(RandomSourceInternal randomSourceInternal) {
 
         final Integer expected = EXPECTED_SEED_BYTES.get(randomSourceInternal);
         Assertions.assertNotNull(expected, () -> "Missing expected seed byte size: " + randomSourceInternal);
-        Assertions.assertEquals(expected.intValue(), size, () -> randomSourceInternal.toString());
+        Assertions.assertEquals(expected.intValue(), size, randomSourceInternal::toString);
     }
 }