Fix PMD UnnecessaryFullyQualifiedName in StringSubstitutor

Author: garydgregory

src/changes/changes.xml

@@ -51,6 +51,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in DefaultStringLookupsHolder.</action>
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in PropertiesStringLookup.</action>
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in JavaPlatformStringLookup.</action>
+    <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in StringSubstitutor.</action>
     <!-- ADD -->
     <action type="add" dev="ggregory" due-to="Gary Gregory">Interface StringLookup now extends UnaryOperator&lt;String&gt;.</action>
     <action type="add" dev="ggregory" due-to="Gary Gregory">Interface TextRandomProvider extends IntUnaryOperator.</action>

src/main/java/org/apache/commons/text/StringSubstitutor.java

@@ -434,8 +434,7 @@ public static String replace(final Object source, final Properties valueProperti
         if (valueProperties == null) {
             return source.toString();
         }
-        return StringSubstitutor.replace(source,
-                valueProperties.stringPropertyNames().stream().collect(Collectors.toMap(Function.identity(), valueProperties::getProperty)));
+        return replace(source, valueProperties.stringPropertyNames().stream().collect(Collectors.toMap(Function.identity(), valueProperties::getProperty)));
     }
 
     /**
@@ -637,7 +636,7 @@ public StringSubstitutor(final StringLookup variableResolver, final StringMatche
     }
 
     /**
-     * Creates a new instance based on the given StringSubstitutor.
+     * Creates a new instance based on the given 
      *
      * @param other The StringSubstitutor used as the source.
      * @since 1.9