Improve performance of encoding Uris (#660)

* Improved performance of UriParser.normalisePath

* Improved performance of UriParser.extractScheme

* Improved performance of UriParser.encode

* Improved performance of UriParser.encode
Make tests compile and uncommented optimisation

* Fix CRLF to LF

Author: japplis

commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/UriParser.java

@@ -217,6 +217,9 @@ public static String encode(final String decodedStr, final char[] reserved) {
         }
         final StringBuilder buffer = new StringBuilder(decodedStr);
         encode(buffer, 0, buffer.length(), reserved);
+        if (buffer.length() == decodedStr.length()) { // No encoding happened
+            return decodedStr;
+        }
         return buffer.toString();
     }
 

commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/UriParserBenchmark.java

@@ -29,11 +29,18 @@
 public class UriParserBenchmark {
 
     private static final String PATH_TO_NORMALIZE = "file:///this/../is/a%2flong%2Fpath/./for testing/normlisePath%2fmethod.txt";
+    private static final String PATH_TO_ENCODE = "file:///this/is/path/to/encode/for/testing/encode.perf";
+    private static final char[] ENCODE_RESERVED = new char[] {' ', '#'};
 
     @Benchmark
     public void normalisePath() throws FileSystemException {
         final StringBuilder path = new StringBuilder(PATH_TO_NORMALIZE);
         UriParser.fixSeparators(path);
         UriParser.normalisePath(path);
     }
+
+    @Benchmark
+    public void encode() throws FileSystemException {
+        UriParser.encode(PATH_TO_ENCODE, ENCODE_RESERVED);
+    }
 }