refactor: cleanup typos

Author: erisu

framework/src/org/apache/cordova/Config.java

@@ -54,7 +54,7 @@ public static String getStartUrl() {
     }
 
     public static String getErrorUrl() {
-        return parser.getPreferences().getString("errorurl", null);
+        return parser.getPreferences().getString("ErrorUrl", null);
     }
 
     public static List<PluginEntry> getPluginEntries() {

framework/src/org/apache/cordova/CordovaActivity.java

@@ -111,7 +111,7 @@ public void onCreate(Bundle savedInstanceState) {
         // need to activate preferences before super.onCreate to avoid "requestFeature() must be called before adding content" exception
         loadConfig();
 
-        String logLevel = preferences.getString("loglevel", "ERROR");
+        String logLevel = preferences.getString("LogLevel", "ERROR");
         LOG.setLogLevel(logLevel);
 
         LOG.i(TAG, "Apache Cordova native platform version " + CordovaWebView.CORDOVA_VERSION + " is starting");

framework/src/org/apache/cordova/CordovaWebViewImpl.java

@@ -75,13 +75,13 @@ public class CordovaWebViewImpl implements CordovaWebView {
     private final Set<Integer> boundKeyCodes = new HashSet<>();
 
     public static CordovaWebViewEngine createEngine(Context context, CordovaPreferences preferences) {
-        String className = preferences.getString("webview", SystemWebViewEngine.class.getCanonicalName());
+        String className = preferences.getString("WebView", SystemWebViewEngine.class.getCanonicalName());
         try {
             Class<?> webViewClass = Class.forName(className);
             Constructor<?> constructor = webViewClass.getConstructor(Context.class, CordovaPreferences.class);
             return (CordovaWebViewEngine) constructor.newInstance(context, preferences);
         } catch (Exception e) {
-            throw new RuntimeException("Failed to create webview. ", e);
+            throw new RuntimeException("Failed to create WebView. ", e);
         }
     }
 
@@ -222,7 +222,7 @@ public void showWebPage(String url, boolean openExternal, boolean clearHistory,
                 loadUrlIntoView(url, true);
                 return;
             } else {
-                LOG.w(TAG, "showWebPage: Refusing to load URL into webview since it is not in the <allow-navigation> allow list. URL=" + url);
+                LOG.w(TAG, "showWebPage: Refusing to load URL into WebView since it is not in the <allow-navigation> allow list. URL=" + url);
                 return;
             }
         }

framework/src/org/apache/cordova/CoreAndroid.java

@@ -273,7 +273,7 @@ public void exitApp() {
     private void initTelephonyReceiver() {
         IntentFilter intentFilter = new IntentFilter();
         intentFilter.addAction(TelephonyManager.ACTION_PHONE_STATE_CHANGED);
-        //final CordovaInterface mycordova = this.cordova;
+        //final CordovaInterface myCordova = this.cordova;
         this.telephonyReceiver = new BroadcastReceiver() {
 
             @Override

framework/src/org/apache/cordova/NativeToJsMessageQueue.java

@@ -491,9 +491,9 @@ void buildJsMessage(StringBuilder sb) {
                 case PluginResult.MESSAGE_TYPE_MULTIPART:
                     int size = pluginResult.getMultipartMessagesSize();
                     for (int i=0; i<size; i++) {
-                        PluginResult subresult = pluginResult.getMultipartMessage(i);
-                        JsMessage submessage = new JsMessage(subresult, jsPayloadOrCallbackId);
-                        submessage.buildJsMessage(sb);
+                        PluginResult subResult = pluginResult.getMultipartMessage(i);
+                        JsMessage subMessage = new JsMessage(subResult, jsPayloadOrCallbackId);
+                        subMessage.buildJsMessage(sb);
                         if (i < (size-1)) {
                             sb.append(",");
                         }

framework/src/org/apache/cordova/engine/SystemWebChromeClient.java

@@ -59,7 +59,7 @@ Licensed to the Apache Software Foundation (ASF) under one
  */
 public class SystemWebChromeClient extends WebChromeClient {
 
-    private static final int FILECHOOSER_RESULTCODE = 5173;
+    private static final int FILE_CHOOSER_RESULT_CODE = 5173;
     private static final String LOG_TAG = "SystemWebChromeClient";
     private final long MAX_QUOTA = 100 * 1024 * 1024;
     protected final SystemWebViewEngine parentEngine;
@@ -294,7 +294,7 @@ public void onActivityResult(int requestCode, int resultCode, Intent intent) {
                     }
                     filePathsCallback.onReceiveValue(result);
                 }
-            }, chooserIntent, FILECHOOSER_RESULTCODE);
+            }, chooserIntent, FILE_CHOOSER_RESULT_CODE);
         } catch (ActivityNotFoundException e) {
             LOG.w(LOG_TAG, "No activity found to handle file chooser intent.", e);
             filePathsCallback.onReceiveValue(null);

framework/src/org/apache/cordova/engine/SystemWebViewEngine.java

@@ -173,13 +173,13 @@ private void initWebViewSettings() {
         // The default is to use the module's debuggable state to decide if the WebView inspector
         // should be enabled. However, users can configure InspectableWebView preference to forcefully enable
         // or disable the WebView inspector.
-        String inspectableWebview = preferences.getString("InspectableWebview", null);
+        String inspectableWebView = preferences.getString("InspectableWebView", null);
         boolean shouldEnableInspector = false;
-        if (inspectableWebview == null) {
+        if (inspectableWebView == null) {
             ApplicationInfo appInfo = webView.getContext().getApplicationContext().getApplicationInfo();
             shouldEnableInspector = (appInfo.flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0;
         }
-        else if ("true".equals(inspectableWebview)) {
+        else if ("true".equals(inspectableWebView)) {
             shouldEnableInspector = true;
         }