Skip to content

Commit 1dc6ecf

Browse files
sanjeewa894stevengill
authored andcommitted
CB-11085 Fix error output using println to LOG.e
This closes #110
1 parent 22f99bc commit 1dc6ecf

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

src/android/AudioHandler.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,8 @@ public float getDurationAudio(String id, String file) {
386386
*/
387387
@SuppressWarnings("deprecation")
388388
public void setAudioOutputDevice(int output) {
389+
private static final String TAG1 = "AudioHandler.setAudioOutputDevice(): Error : ";
390+
389391
AudioManager audiMgr = (AudioManager) this.cordova.getActivity().getSystemService(Context.AUDIO_SERVICE);
390392
if (output == 2) {
391393
audiMgr.setRouting(AudioManager.MODE_NORMAL, AudioManager.ROUTE_SPEAKER, AudioManager.ROUTE_ALL);
@@ -394,7 +396,7 @@ else if (output == 1) {
394396
audiMgr.setRouting(AudioManager.MODE_NORMAL, AudioManager.ROUTE_EARPIECE, AudioManager.ROUTE_ALL);
395397
}
396398
else {
397-
System.out.println("AudioHandler.setAudioOutputDevice() Error: Unknown output device.");
399+
LOG.e(TAG1," Unknown output device");
398400
}
399401
}
400402

@@ -435,13 +437,15 @@ public void onAudioFocusChange(int focusChange) {
435437
};
436438

437439
public void getAudioFocus() {
440+
private static final String TAG2 = "AudioHandler.getAudioFocus(): Error : ";
441+
438442
AudioManager am = (AudioManager) this.cordova.getActivity().getSystemService(Context.AUDIO_SERVICE);
439443
int result = am.requestAudioFocus(focusChangeListener,
440444
AudioManager.STREAM_MUSIC,
441445
AudioManager.AUDIOFOCUS_GAIN);
442446

443447
if (result != AudioManager.AUDIOFOCUS_REQUEST_GRANTED) {
444-
System.out.println("AudioHandler.getAudioFocus() Error: Got " + result + " instead of " + AudioManager.AUDIOFOCUS_REQUEST_GRANTED);
448+
LOG.e(TAG2,result + " instead of " + AudioManager.AUDIOFOCUS_REQUEST_GRANTED);
445449
}
446450

447451
}
@@ -473,11 +477,13 @@ else if (audiMgr.getRouting(AudioManager.MODE_NORMAL) == AudioManager.ROUTE_SPEA
473477
* @param volume Volume to adjust to 0.0f - 1.0f
474478
*/
475479
public void setVolume(String id, float volume) {
480+
private static final String TAG3 = "AudioHandler.setVolume(): Error : ";
481+
476482
AudioPlayer audio = this.players.get(id);
477483
if (audio != null) {
478484
audio.setVolume(volume);
479485
} else {
480-
System.out.println("AudioHandler.setVolume() Error: Unknown Audio Player " + id);
486+
LOG.e(TAG3,"Unknown Audio Player " + id);
481487
}
482488
}
483489

0 commit comments

Comments
 (0)