Skip to content

Commit 7123060

Browse files
authored
Fix flaky TestReadOnly.testConnectionStateNewClient in ZooKeeper 3.9.3 (#1272)
ZOOKEEPER-4508 reports `SessionExpired` after exhausting session timeout in session establishment instead of endless retries. It is easy to get in this now with small session timeout. Besides above, `sessionTimeoutMs` should bigger than `connectionTimeoutMs`, while default `Timing::session()` and `Timing::connection()` are `2s` and `10s` respectively now. ``` // from CuratorZookeeperClient if (sessionTimeoutMs < connectionTimeoutMs) { log.warn( "session timeout [{}] is less than connection timeout [{}]", sessionTimeoutMs, connectionTimeoutMs); } ```
1 parent fcd708f commit 7123060

File tree

1 file changed

+1
-1
lines changed
  • curator-test/src/main/java/org/apache/curator/test

1 file changed

+1
-1
lines changed

curator-test/src/main/java/org/apache/curator/test/Timing.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class Timing {
3333

3434
private static final int DEFAULT_SECONDS = 10;
3535
private static final int DEFAULT_WAITING_MULTIPLE = 5;
36-
private static final double SESSION_MULTIPLE = .25;
36+
private static final double SESSION_MULTIPLE = 1.5;
3737

3838
/**
3939
* Use the default base time

0 commit comments

Comments
 (0)