Skip to content

Commit 331f7bb

Browse files
chore: Remove all subdependencies (#1514)
* Remove all subdependencies * rebase and resolve conflicts * fmt --------- Co-authored-by: Emily Matheys <[email protected]>
1 parent d92c209 commit 331f7bb

File tree

92 files changed

+504
-549
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

92 files changed

+504
-549
lines changed

docs/source/contributor-guide/debugging.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,8 @@ org.apache.comet.CometNativeException: Internal error: MIN/MAX is not expected t
142142

143143
backtrace:
144144
0: std::backtrace::Backtrace::create
145-
1: datafusion_physical_expr::aggregate::min_max::min
146-
2: <datafusion_physical_expr::aggregate::min_max::MinAccumulator as datafusion_expr::accumulator::Accumulator>::update_batch
145+
1: datafusion::physical_expr::aggregate::min_max::min
146+
2: <datafusion::physical_expr::aggregate::min_max::MinAccumulator as datafusion_expr::accumulator::Accumulator>::update_batch
147147
3: <futures_util::stream::stream::fuse::Fuse<S> as futures_core::stream::Stream>::poll_next
148148
4: comet::execution::jni_api::Java_org_apache_comet_Native_executePlan::{{closure}}
149149
5: _Java_org_apache_comet_Native_executePlan

native/Cargo.lock

Lines changed: 1 addition & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

native/Cargo.toml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,10 @@ rust-version = "1.85"
3535

3636
[workspace.dependencies]
3737
arrow = { version = "54.2.0", features = ["prettyprint", "ffi", "chrono-tz"] }
38-
arrow-array = { version = "54.2.0" }
39-
arrow-buffer = { version = "54.2.0" }
40-
arrow-data = { version = "54.2.0" }
41-
arrow-schema = { version = "54.2.0" }
4238
async-trait = { version = "0.1" }
4339
bytes = { version = "1.10.0" }
4440
parquet = { version = "54.2.0", default-features = false, features = ["experimental"] }
45-
datafusion = { version = "46.0.0", default-features = false, features = ["unicode_expressions", "crypto_expressions"] }
46-
datafusion-common = { version = "46.0.0", default-features = false }
47-
datafusion-datasource = { version = "46.0.0", default-features = false }
48-
datafusion-functions = { version = "46.0.0", default-features = false, features = ["crypto_expressions"] }
49-
datafusion-functions-nested = { version = "46.0.0", default-features = false }
50-
datafusion-expr = { version = "46.0.0", default-features = false }
51-
datafusion-expr-common = { version = "46.0.0", default-features = false }
52-
datafusion-execution = { version = "46.0.0", default-features = false }
53-
datafusion-physical-expr = { version = "46.0.0", default-features = false }
41+
datafusion = { version = "46.0.0", default-features = false, features = ["unicode_expressions", "crypto_expressions", "nested_expressions", "parquet"] }
5442
datafusion-comet-spark-expr = { path = "spark-expr", version = "0.7.0" }
5543
datafusion-comet-proto = { path = "proto", version = "0.7.0" }
5644
chrono = { version = "0.4", default-features = false, features = ["clock"] }

native/core/Cargo.toml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@ publish = false
3636

3737
[dependencies]
3838
arrow = { workspace = true }
39-
arrow-array = { workspace = true }
40-
arrow-buffer = { workspace = true }
41-
arrow-data = { workspace = true }
42-
arrow-schema = { workspace = true }
4339
parquet = { workspace = true, default-features = false, features = ["experimental"] }
4440
futures = { workspace = true }
4541
mimalloc = { version = "*", default-features = false, optional = true }
@@ -62,12 +58,7 @@ bytes = { workspace = true }
6258
tempfile = "3.8.0"
6359
itertools = "0.14.0"
6460
paste = "1.0.14"
65-
datafusion-common = { workspace = true, features= ["object_store"] }
6661
datafusion = { workspace = true }
67-
datafusion-functions-nested = { workspace = true }
68-
datafusion-expr = { workspace = true }
69-
datafusion-execution = { workspace = true }
70-
datafusion-physical-expr = { workspace = true }
7162
once_cell = "1.18.0"
7263
regex = { workspace = true }
7364
crc32fast = "1.3.2"

native/core/benches/bloom_filter_agg.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,22 @@
1515
// specific language governing permissions and limitations
1616
// under the License.use arrow::array::{ArrayRef, BooleanBuilder, Int32Builder, RecordBatch, StringBuilder};
1717

18+
use arrow::array::builder::Int64Builder;
19+
use arrow::array::{ArrayRef, RecordBatch};
20+
use arrow::datatypes::SchemaRef;
1821
use arrow::datatypes::{DataType, Field, Schema};
19-
use arrow_array::builder::Int64Builder;
20-
use arrow_array::{ArrayRef, RecordBatch};
21-
use arrow_schema::SchemaRef;
2222
use comet::execution::expressions::bloom_filter_agg::BloomFilterAgg;
2323
use criterion::{black_box, criterion_group, criterion_main, Criterion};
24+
use datafusion::common::ScalarValue;
2425
use datafusion::datasource::memory::MemorySourceConfig;
2526
use datafusion::datasource::source::DataSourceExec;
27+
use datafusion::execution::TaskContext;
28+
use datafusion::logical_expr::AggregateUDF;
29+
use datafusion::physical_expr::aggregate::AggregateExprBuilder;
30+
use datafusion::physical_expr::expressions::{Column, Literal};
2631
use datafusion::physical_expr::PhysicalExpr;
2732
use datafusion::physical_plan::aggregates::{AggregateExec, AggregateMode, PhysicalGroupBy};
2833
use datafusion::physical_plan::ExecutionPlan;
29-
use datafusion_common::ScalarValue;
30-
use datafusion_execution::TaskContext;
31-
use datafusion_expr::AggregateUDF;
32-
use datafusion_physical_expr::aggregate::AggregateExprBuilder;
33-
use datafusion_physical_expr::expressions::{Column, Literal};
3434
use futures::StreamExt;
3535
use std::sync::Arc;
3636
use std::time::Duration;

native/core/benches/common.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18+
use arrow::error::ArrowError;
1819
use arrow::{
1920
array::{DictionaryArray, Int64Array, PrimitiveArray},
2021
datatypes::{ArrowPrimitiveType, Int32Type},
2122
};
22-
use arrow_schema::ArrowError;
2323
use rand::{
2424
distributions::{Distribution, Standard},
2525
rngs::StdRng,

native/core/benches/filter.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
// specific language governing permissions and limitations
1616
// under the License.use arrow::array::{ArrayRef, BooleanBuilder, Int32Builder, RecordBatch, StringBuilder};
1717

18+
use arrow::array::builder::{BooleanBuilder, Int32Builder, StringBuilder};
19+
use arrow::array::{ArrayRef, RecordBatch};
1820
use arrow::compute::filter_record_batch;
1921
use arrow::datatypes::{DataType, Field, Schema};
20-
use arrow_array::builder::{BooleanBuilder, Int32Builder, StringBuilder};
21-
use arrow_array::{ArrayRef, RecordBatch};
2222
use comet::execution::operators::comet_filter_record_batch;
2323
use criterion::{black_box, criterion_group, criterion_main, Criterion};
2424
use std::sync::Arc;

native/core/benches/parquet_decode.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
use arrow_buffer::ToByteSlice;
18+
use arrow::datatypes::ToByteSlice;
1919
use comet::parquet::read::values::{copy_i32_to_i16, copy_i32_to_u16, copy_i64_to_i64};
2020
use criterion::{criterion_group, criterion_main, Criterion};
2121

native/core/benches/shuffle_writer.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,19 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
use arrow_array::builder::{Date32Builder, Decimal128Builder, Int32Builder};
19-
use arrow_array::{builder::StringBuilder, RecordBatch};
20-
use arrow_schema::{DataType, Field, Schema};
18+
use arrow::array::builder::{Date32Builder, Decimal128Builder, Int32Builder};
19+
use arrow::array::{builder::StringBuilder, RecordBatch};
20+
use arrow::datatypes::{DataType, Field, Schema};
2121
use comet::execution::shuffle::{CompressionCodec, ShuffleBlockWriter, ShuffleWriterExec};
2222
use criterion::{criterion_group, criterion_main, Criterion};
2323
use datafusion::datasource::memory::MemorySourceConfig;
2424
use datafusion::datasource::source::DataSourceExec;
25+
use datafusion::physical_expr::{expressions::Column, Partitioning};
2526
use datafusion::physical_plan::metrics::Time;
2627
use datafusion::{
2728
physical_plan::{common::collect, ExecutionPlan},
2829
prelude::SessionContext,
2930
};
30-
use datafusion_physical_expr::{expressions::Column, Partitioning};
3131
use std::io::Cursor;
3232
use std::sync::Arc;
3333
use tokio::runtime::Runtime;

native/core/src/errors.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
//! Common Parquet errors and macros.
1919
2020
use arrow::error::ArrowError;
21-
use datafusion_common::DataFusionError;
21+
use datafusion::common::DataFusionError;
2222
use jni::errors::{Exception, ToException};
2323
use regex::Regex;
2424

0 commit comments

Comments
 (0)