Skip to content

Commit 587c29b

Browse files
authored
chore: Remove unused StringView struct (#1143)
* Remove unused StringView struct * remove more dead code
1 parent 8d7bcb8 commit 587c29b

File tree

3 files changed

+0
-262
lines changed

3 files changed

+0
-262
lines changed

native/core/src/common/mod.rs

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,5 @@
1717

1818
#[macro_use]
1919
pub mod bit;
20-
21-
use crate::TypeTrait;
22-
23-
/// Getter APIs for Comet vectors.
24-
trait ValueGetter<T: TypeTrait> {
25-
/// Gets the non-null value at `idx`.
26-
///
27-
/// Note that null check needs to be done before the call, to ensure the value at `idx` is
28-
/// not null.
29-
fn value(&self, idx: usize) -> T::Native;
30-
}
31-
32-
/// Setter APIs for Comet mutable vectors.
33-
trait ValueSetter<T: TypeTrait> {
34-
/// Appends a non-null value `v` to the end of this vector.
35-
fn append_value(&mut self, v: &T::Native);
36-
}
37-
3820
mod buffer;
3921
pub use buffer::*;

native/core/src/data_type.rs

Lines changed: 0 additions & 241 deletions
This file was deleted.

native/core/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,12 @@ use log4rs::{
4040
use mimalloc::MiMalloc;
4141
use once_cell::sync::OnceCell;
4242

43-
pub use data_type::*;
44-
4543
use errors::{try_unwrap_or_throw, CometError, CometResult};
4644

4745
#[macro_use]
4846
mod errors;
4947
#[macro_use]
5048
pub mod common;
51-
mod data_type;
5249
pub mod execution;
5350
mod jvm_bridge;
5451
pub mod parquet;

0 commit comments

Comments
 (0)