Skip to content

Commit 5f204c9

Browse files
authored
feat: support cot (#2755)
1 parent 20be79d commit 5f204c9

File tree

4 files changed

+5
-1
lines changed

4 files changed

+5
-1
lines changed

docs/source/user-guide/latest/expressions.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ incompatible expressions.
128128
| BRound | `bround` | Yes | |
129129
| Ceil | `ceil` | Yes | |
130130
| Cos | `cos` | Yes | |
131+
| Cot | `cot` | Yes | |
131132
| Divide | `/` | Yes | |
132133
| Exp | `exp` | Yes | |
133134
| Expm1 | `expm1` | Yes | |

fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ object Meta {
114114
createUnaryNumericFunction("sin"),
115115
createUnaryNumericFunction("sqrt"),
116116
createUnaryNumericFunction("tan"),
117+
createUnaryNumericFunction("cot"),
117118
createUnaryNumericFunction("ceil"),
118119
createUnaryNumericFunction("floor"),
119120
createFunctionWithInputTypes("unary_minus", Seq(SparkNumericType)))

spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
115115
classOf[Sqrt] -> CometScalarFunction("sqrt"),
116116
classOf[Subtract] -> CometSubtract,
117117
classOf[Tan] -> CometScalarFunction("tan"),
118+
classOf[Cot] -> CometScalarFunction("cot"),
118119
classOf[UnaryMinus] -> CometUnaryMinus,
119120
classOf[Unhex] -> CometUnhex,
120121
classOf[Abs] -> CometAbs)

spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1352,7 +1352,8 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
13521352
"log2",
13531353
"sin",
13541354
"sqrt",
1355-
"tan")) {
1355+
"tan",
1356+
"cot")) {
13561357
val (_, cometPlan) =
13571358
checkSparkAnswerAndOperatorWithTol(sql(s"SELECT $expr(_1), $expr(_2) FROM tbl"))
13581359
val cometProjectExecs = collect(cometPlan) { case op: CometProjectExec =>

0 commit comments

Comments
 (0)