native_integral_decimal_cast_support

Author: coderfender

native/spark-expr/src/conversion_funcs/cast.rs

@@ -1501,20 +1501,24 @@ where
                         builder.append_value(scaled);
                     }
                 }
-                _ => {
-                    return Err(SparkError::NumericValueOutOfRange {
-                        value: v.to_string(),
-                        precision,
-                        scale,
-                    })
-                }
+                _ => match eval_mode {
+                    EvalMode::Ansi => {
+                        return Err(SparkError::NumericValueOutOfRange {
+                            value: v.to_string(),
+                            precision,
+                            scale,
+                        })
+                    }
+                    EvalMode::Legacy | EvalMode::Try => builder.append_null(),
+                },
             }
         }
     }
     Ok(Arc::new(
         builder.with_precision_and_scale(precision, scale)?.finish(),
     ))
 }
+
 fn cast_int_to_decimal128(
     array: &dyn Array,
     eval_mode: EvalMode,

spark/src/test/scala/org/apache/comet/CometCastSuite.scala

@@ -332,6 +332,14 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
     castTest(intToDecimal10OverflowValues, DataTypes.createDecimalType(10, 2))
   }
 
+  test("cast IntegerType to DecimalType check arbitrary scale and precision") {
+    Seq(DecimalType.MAX_PRECISION, DecimalType.MAX_SCALE, 0, 10, 15)
+      .combinations(2)
+      .map({ c =>
+        castTest(generateInts(), DataTypes.createDecimalType(c.head, c.last))
+      })
+  }
+
   test("cast IntegerType to StringType") {
     castTest(generateInts(), DataTypes.StringType)
   }
@@ -1236,7 +1244,6 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
             case (None, None) =>
             // neither system threw an exception
             case (None, Some(e)) =>
-              // Spark succeeded but Comet failed
               throw e
             case (Some(e), None) =>
               // Spark failed but Comet succeeded