Skip to content

Commit 72a8664

Browse files
committed
rename
1 parent 108224a commit 72a8664

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

common/src/main/scala/org/apache/comet/CometConf.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ object CometConf extends ShimCometConf {
511511
.createWithDefault(false)
512512

513513
val COMET_ENABLE_ONHEAP_MODE: ConfigEntry[Boolean] =
514-
conf("spark.comet.exec.onheap.enabled")
514+
conf("spark.comet.exec.onHeap.enabled")
515515
.doc("Whether to allow Comet to run in on-heap mode. Required for running Spark SQL tests.")
516516
.booleanConf
517517
.createWithDefault(sys.env.getOrElse("ENABLE_COMET_ONHEAP", "false").toBoolean)

docs/source/user-guide/latest/configs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Comet provides the following configuration settings.
5050
| spark.comet.exec.hashJoin.enabled | Whether to enable hashJoin by default. | true |
5151
| spark.comet.exec.localLimit.enabled | Whether to enable localLimit by default. | true |
5252
| spark.comet.exec.memoryPool | The type of memory pool to be used for Comet native execution. When running Spark in on-heap mode, available pool types are 'greedy', 'fair_spill', 'greedy_task_shared', 'fair_spill_task_shared', 'greedy_global', 'fair_spill_global', and `unbounded`. When running Spark in off-heap mode, available pool types are 'greedy_unified' and `fair_unified`. The default pool type is `greedy_task_shared` for on-heap mode and `unified` for off-heap mode. For more information, refer to the Comet Tuning Guide (https://datafusion.apache.org/comet/user-guide/tuning.html). | default |
53-
| spark.comet.exec.onheap.enabled | Whether to allow Comet to run in on-heap mode. Required for running Spark SQL tests. | false |
53+
| spark.comet.exec.onHeap.enabled | Whether to allow Comet to run in on-heap mode. Required for running Spark SQL tests. | false |
5454
| spark.comet.exec.project.enabled | Whether to enable project by default. | true |
5555
| spark.comet.exec.replaceSortMergeJoin | Experimental feature to force Spark to replace SortMergeJoin with ShuffledHashJoin for improved performance. This feature is not stable yet. For more information, refer to the Comet Tuning Guide (https://datafusion.apache.org/comet/user-guide/tuning.html). | false |
5656
| spark.comet.exec.shuffle.compression.codec | The codec of Comet native shuffle used to compress shuffle data. lz4, zstd, and snappy are supported. Compression can be disabled by setting spark.shuffle.compress=false. | lz4 |

docs/source/user-guide/latest/tuning.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ section of this guide.
5656
Support for on-heap memory pools is deprecated and will be removed from a future release.
5757
```
5858

59-
Comet is disabled by default in on-heap mode, but can be enabled by setting `spark.comet.exec.onheap.enabled=true`.
59+
Comet is disabled by default in on-heap mode, but can be enabled by setting `spark.comet.exec.onHeap.enabled=true`.
6060

6161
When running in on-heap mode, Comet memory can be allocated by setting `spark.comet.memoryOverhead`. If this setting
6262
is not provided, it will be calculated by multiplying the current Spark executor memory by

spark/src/test/scala/org/apache/spark/CometPluginsSuite.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class CometPluginsSuite extends CometTestBase {
3131
conf.set("spark.plugins", "org.apache.spark.CometPlugin")
3232
conf.set("spark.comet.enabled", "true")
3333
conf.set("spark.comet.exec.enabled", "true")
34-
conf.set("spark.comet.exec.onheap.enabled", "true")
34+
conf.set("spark.comet.exec.onHeap.enabled", "true")
3535
conf
3636
}
3737

@@ -100,7 +100,7 @@ class CometPluginsDefaultSuite extends CometTestBase {
100100
conf.set("spark.plugins", "org.apache.spark.CometPlugin")
101101
conf.set("spark.comet.enabled", "true")
102102
conf.set("spark.comet.exec.shuffle.enabled", "true")
103-
conf.set("spark.comet.exec.onheap.enabled", "true")
103+
conf.set("spark.comet.exec.onHeap.enabled", "true")
104104
conf
105105
}
106106

@@ -130,7 +130,7 @@ class CometPluginsNonOverrideSuite extends CometTestBase {
130130
conf.set("spark.comet.enabled", "true")
131131
conf.set("spark.comet.exec.shuffle.enabled", "false")
132132
conf.set("spark.comet.exec.enabled", "false")
133-
conf.set("spark.comet.exec.onheap.enabled", "true")
133+
conf.set("spark.comet.exec.onHeap.enabled", "true")
134134
conf
135135
}
136136

0 commit comments

Comments
 (0)