Skip to content

Commit 7ae31c9

Browse files
andygrovehsiang-c
andauthored
fix merge conflict (#2535)
Co-authored-by: hsiang-c <[email protected]>
1 parent 8ee8b76 commit 7ae31c9

File tree

2 files changed

+1889
-3
lines changed

2 files changed

+1889
-3
lines changed

dev/diffs/iceberg/1.8.1.diff

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ index 7327b38905d..7967109f039 100644
1717
exclude group: 'org.apache.avro', module: 'avro'
1818
// already shaded by Parquet
1919
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
20-
index 04ffa8f4edc..cc0099ccc93 100644
20+
index 04ffa8f4edc..a909cd552c1 100644
2121
--- a/gradle/libs.versions.toml
2222
+++ b/gradle/libs.versions.toml
2323
@@ -34,6 +34,7 @@ azuresdk-bom = "1.2.31"
@@ -300,10 +300,10 @@ index 00000000000..ddf6c7de5ae
300300
+}
301301
diff --git a/parquet/src/main/java/org/apache/iceberg/parquet/CometVectorizedParquetReader.java b/parquet/src/main/java/org/apache/iceberg/parquet/CometVectorizedParquetReader.java
302302
new file mode 100644
303-
index 00000000000..88b195b76a2
303+
index 00000000000..a3cba401827
304304
--- /dev/null
305305
+++ b/parquet/src/main/java/org/apache/iceberg/parquet/CometVectorizedParquetReader.java
306-
@@ -0,0 +1,255 @@
306+
@@ -0,0 +1,260 @@
307307
+/*
308308
+ * Licensed to the Apache Software Foundation (ASF) under one
309309
+ * or more contributor license agreements. See the NOTICE file
@@ -446,6 +446,7 @@ index 00000000000..88b195b76a2
446446
+ private long valuesRead = 0;
447447
+ private T last = null;
448448
+ private final FileReader cometReader;
449+
+ private ReadConf conf;
449450
+
450451
+ FileIterator(
451452
+ ReadConf conf,
@@ -470,6 +471,7 @@ index 00000000000..88b195b76a2
470471
+ length,
471472
+ fileEncryptionKey,
472473
+ fileAADPrefix);
474+
+ this.conf = conf;
473475
+ }
474476
+
475477
+ private FileReader newCometReader(
@@ -556,6 +558,9 @@ index 00000000000..88b195b76a2
556558
+ public void close() throws IOException {
557559
+ model.close();
558560
+ cometReader.close();
561+
+ if (conf != null && conf.reader() != null) {
562+
+ conf.reader().close();
563+
+ }
559564
+ }
560565
+ }
561566
+}

0 commit comments

Comments
 (0)