fix: cast timestamp to decimal is unsupported (#1281)

wForget · web-flow · commit 9c1f0ee1934e · 2025-01-14T09:57:52.000-07:00
* fix: cast timestamp to decimal is unsupported

* fix style

* revert test name and mark as ignore

* add comment
diff --git a/spark/src/main/scala/org/apache/comet/expressions/CometCast.scala b/spark/src/main/scala/org/apache/comet/expressions/CometCast.scala
@@ -204,7 +204,6 @@ object CometCast {
         Compatible()
       case DataTypes.StringType => Compatible()
       case DataTypes.DateType => Compatible()
-      case _: DecimalType => Compatible()
       case _ => Unsupported
     }
   }
diff --git a/spark/src/test/scala/org/apache/comet/CometCastSuite.scala b/spark/src/test/scala/org/apache/comet/CometCastSuite.scala
@@ -838,8 +838,10 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
     castTest(generateTimestamps(), DataTypes.DoubleType)
   }
 
-  test("cast TimestampType to DecimalType(10,2)") {
-    castTest(generateTimestamps(), DataTypes.TimestampType)
+  ignore("cast TimestampType to DecimalType(10,2)") {
+    // https://github.com/apache/datafusion-comet/issues/1280
+    // Native cast invoked for unsupported cast from Timestamp(Microsecond, Some("Etc/UTC")) to Decimal128(10, 2)
+    castTest(generateTimestamps(), DataTypes.createDecimalType(10, 2))
   }
 
   test("cast TimestampType to StringType") {

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,6 @@ object CometCast {`
`204`	`204`	`Compatible()`
`205`	`205`	`case DataTypes.StringType => Compatible()`
`206`	`206`	`case DataTypes.DateType => Compatible()`
`207`		`- case _: DecimalType => Compatible()`
`208`	`207`	`case _ => Unsupported`
`209`	`208`	`}`
`210`	`209`	`}`
Original file line number	Diff line number	Diff line change
`@@ -838,8 +838,10 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {`
`838`	`838`	`castTest(generateTimestamps(), DataTypes.DoubleType)`
`839`	`839`	`}`
`840`	`840`
`841`		`- test("cast TimestampType to DecimalType(10,2)") {`
`842`		`- castTest(generateTimestamps(), DataTypes.TimestampType)`
	`841`	`+ ignore("cast TimestampType to DecimalType(10,2)") {`
	`842`	`+ // https://github.com/apache/datafusion-comet/issues/1280`
	`843`	`+ // Native cast invoked for unsupported cast from Timestamp(Microsecond, Some("Etc/UTC")) to Decimal128(10, 2)`
	`844`	`+ castTest(generateTimestamps(), DataTypes.createDecimalType(10, 2))`
`843`	`845`	`}`
`844`	`846`
`845`	`847`	`test("cast TimestampType to StringType") {`