wip_sum_tests

Author: coderfender

native/.DS_Store

@@ -64,7 +64,7 @@ use datafusion::{
 use datafusion_comet_spark_expr::{
     create_comet_physical_fun, create_comet_physical_fun_with_eval_mode, create_modulo_expr,
     create_negate_expr, BinaryOutputStyle, BloomFilterAgg, BloomFilterMightContain, EvalMode,
-    SparkHour, SparkMinute, SparkSecond,
+    SparkHour, SparkMinute, SparkSecond, SumInteger,
 };
 
 use crate::execution::operators::ExecutionError::GeneralError;
@@ -1875,6 +1875,17 @@ impl PhysicalPlanner {
                         let func = AggregateUDF::new_from_impl(SumDecimal::try_new(datatype)?);
                         AggregateExprBuilder::new(Arc::new(func), vec![child])
                     }
+                    DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => {
+                        // let eval_mode = let eval_mode = from_protobuf_eval_mode(expr.eval_mode)?;
+                        let eval_mode = if expr.fail_on_error {
+                            EvalMode::Ansi
+                        } else {
+                            EvalMode::Legacy
+                        };
+                        let func =
+                            AggregateUDF::new_from_impl(SumInteger::try_new(datatype, eval_mode)?);
+                        AggregateExprBuilder::new(Arc::new(func), vec![child])
+                    }
                     _ => {
                         // cast to the result data type of SUM if necessary, we should not expect
                         // a cast failure since it should have already been checked at Spark side

native/core/src/execution/planner.rs

@@ -30,4 +30,5 @@ pub use correlation::Correlation;
 pub use covariance::Covariance;
 pub use stddev::Stddev;
 pub use sum_decimal::SumDecimal;
+pub use sum_int::SumInteger;
 pub use variance::Variance;